Skip to content

feat: enable null reference type support #2146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 56 commits into from
Mar 14, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
56bb532
feat: enable NRT
MaggieKimani1 Feb 13, 2025
b3b5663
fix: dereference of a possible null reference
MaggieKimani1 Feb 13, 2025
c99dfc3
Merge branch 'main' into feat/enable-NRT
MaggieKimani1 Feb 13, 2025
489fa4d
chore: code cleanup
MaggieKimani1 Feb 14, 2025
0b6b07d
chore: convert to conditional expression
MaggieKimani1 Feb 14, 2025
f13a9e4
Update src/Microsoft.OpenApi/Models/OpenApiOperation.cs
MaggieKimani1 Feb 17, 2025
b7b845c
Update src/Microsoft.OpenApi/Models/OpenApiRequestBody.cs
MaggieKimani1 Feb 21, 2025
ea5c389
chore: PR feedback
MaggieKimani1 Feb 21, 2025
78b8d88
Merge branch 'main' into feat/enable-NRT
MaggieKimani1 Feb 21, 2025
1b793a4
fix: resolve merge conflict errors
MaggieKimani1 Feb 24, 2025
3df5c98
chore: remove deprecated code and tests; make param required
MaggieKimani1 Feb 24, 2025
69a2b9b
chore: code refactor and cleanup
MaggieKimani1 Feb 24, 2025
2133509
chore: update public API
MaggieKimani1 Feb 24, 2025
d990121
chore: address PR comments
MaggieKimani1 Feb 25, 2025
80edd66
fix: remove nullable Json node params
MaggieKimani1 Feb 25, 2025
2749a3e
chore: use conditional compilation to make reference a required field
MaggieKimani1 Feb 27, 2025
fa012ac
Merge branch 'main' into feat/enable-NRT
MaggieKimani1 Feb 27, 2025
d016afd
chore: resolve merge conflicts
MaggieKimani1 Feb 27, 2025
fd15b0a
Merge branch 'main' into feat/enable-NRT
MaggieKimani1 Feb 27, 2025
9ef1bb0
chore: resolve merge conflicts
MaggieKimani1 Feb 27, 2025
07b3a2c
refactor: apply nullable to new changes
MaggieKimani1 Feb 27, 2025
cd41026
Merge branch 'main' into feat/enable-NRT
baywet Feb 27, 2025
ad59b9c
chore: bad merge
baywet Feb 27, 2025
b1b2fc5
Merge branch 'main' into feat/enable-NRT
baywet Mar 3, 2025
b6d68bb
chore: simplifies filtering condition
baywet Mar 3, 2025
e6cc29c
Update src/Microsoft.OpenApi/Models/OpenApiRequestBody.cs
MaggieKimani1 Mar 4, 2025
8a4fcc2
chore: address more PR feedback
MaggieKimani1 Mar 4, 2025
6116afe
chore: pull latest changes
MaggieKimani1 Mar 4, 2025
0805d89
chore: add check for both null and empty strings
MaggieKimani1 Mar 4, 2025
0a690ff
chore: revert to include check for empty strings
MaggieKimani1 Mar 4, 2025
af8a41c
chore: cleanup
MaggieKimani1 Mar 4, 2025
d9afa53
Merge branch 'main' into feat/enable-NRT
MaggieKimani1 Mar 4, 2025
cd4de69
chore: clean up public API
MaggieKimani1 Mar 4, 2025
0176234
Update src/Microsoft.OpenApi/Reader/Services/OpenApiRemoteReferenceCo…
MaggieKimani1 Mar 10, 2025
2e0b42d
fix: resolve PR feedback
MaggieKimani1 Mar 11, 2025
7f71fb7
fix: apply suggestion
MaggieKimani1 Mar 11, 2025
7a9b01e
chore: Merge remote-tracking branch 'origin/main' into feat/enable-NRT
MaggieKimani1 Mar 12, 2025
c5caa27
chore: add defensive programming
MaggieKimani1 Mar 12, 2025
02c95e8
Merge branch 'main' into feat/enable-NRT
MaggieKimani1 Mar 12, 2025
ff0d877
chore: resolve merge conflicts
MaggieKimani1 Mar 12, 2025
2dcc72e
chore: more refactoring
MaggieKimani1 Mar 12, 2025
0aea73f
Update src/Microsoft.OpenApi/Reader/V2/OpenApiOperationDeserializer.cs
MaggieKimani1 Mar 12, 2025
f942764
Update src/Microsoft.OpenApi/Reader/V2/OpenApiPathItemDeserializer.cs
MaggieKimani1 Mar 12, 2025
e545160
Update src/Microsoft.OpenApi/Reader/V31/OpenApiServerVariableDeserial…
MaggieKimani1 Mar 12, 2025
6cc7497
Update src/Microsoft.OpenApi/Reader/V31/OpenApiSecurityRequirementDes…
MaggieKimani1 Mar 12, 2025
93ac7f0
Update src/Microsoft.OpenApi/Reader/V2/OpenApiSecurityRequirementDese…
MaggieKimani1 Mar 12, 2025
571b537
Update src/Microsoft.OpenApi/Reader/V3/OpenApiServerVariableDeseriali…
MaggieKimani1 Mar 12, 2025
69ef5c0
Update src/Microsoft.OpenApi/Reader/V3/OpenApiSecurityRequirementDese…
MaggieKimani1 Mar 12, 2025
81e0682
chore: another round of refactoring
MaggieKimani1 Mar 12, 2025
d9a7bec
chore: clean up nullability of params
MaggieKimani1 Mar 13, 2025
32568e8
fix: compiler errors
MaggieKimani1 Mar 13, 2025
f608cea
fix: remove redundant cast and update public API
MaggieKimani1 Mar 13, 2025
2f8ea28
Merge branch 'main' into feat/enable-NRT
MaggieKimani1 Mar 13, 2025
50b06c4
chore: fix merge conflict issues
MaggieKimani1 Mar 13, 2025
c9b8f4f
chore: apply copilot suggestion
MaggieKimani1 Mar 13, 2025
2a12fa7
Update src/Microsoft.OpenApi/Services/OpenApiWalker.cs
baywet Mar 14, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into feat/enable-NRT
  • Loading branch information
MaggieKimani1 authored Feb 13, 2025
commit c99dfc336a9664cf0d3b55c42f2b1e333e317628
9 changes: 6 additions & 3 deletions src/Microsoft.OpenApi/Reader/V3/OpenApiV3Deserializer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -138,15 +138,15 @@

private static IOpenApiExtension LoadExtension(string name, ParseNode node)
{
if (node.Context.ExtensionParsers is not null && node.Context.ExtensionParsers.TryGetValue(name, out var parser) && parser(
node.CreateAny(), OpenApiSpecVersion.OpenApi3_0) is { } result)
{
return result;
}
else
{
return new OpenApiAny(node.CreateAny());
}

Check notice

Code scanning / CodeQL

Missed ternary opportunity Note

Both branches of this 'if' statement return - consider using '?' to express intent better.
}

private static string? LoadString(ParseNode node)
Expand All @@ -159,9 +159,12 @@
var refSegments = pointer.Split('/');
var refId = refSegments[refSegments.Count() -1];
var isExternalResource = !refSegments[0].StartsWith("#", StringComparison.OrdinalIgnoreCase);

string? externalResource = isExternalResource ? $"{refSegments[0]}/{refSegments[1].TrimEnd('#')}" : null;


string? externalResource = null;
if (isExternalResource)
{
externalResource = pointer.Split('#')[0].TrimEnd('#');
}
return (refId, externalResource);
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -137,14 +137,14 @@

private static IOpenApiExtension LoadExtension(string name, ParseNode node)
{
if (node.Context.ExtensionParsers is not null && node.Context.ExtensionParsers.TryGetValue(name, out var parser))
{
return parser(node.CreateAny(), OpenApiSpecVersion.OpenApi3_1);
}
else
{
return new OpenApiAny(node.CreateAny());
}
}

private static string? LoadString(ParseNode node)
Expand Down Expand Up @@ -173,7 +173,7 @@
string? externalResource = null;
if (isExternalResource && pointer.Contains('#'))
{
externalResource = $"{refSegments[0]}/{refSegments[1].TrimEnd('#')}";
externalResource = pointer.Split('#')[0].TrimEnd('#');
}

return (refId, externalResource);
Expand Down
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.