Skip to content

DOM: Add Support for pageswap and pagereveal event on window #1974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2025

Conversation

kyohei-23
Copy link
Contributor

@kyohei-23 kyohei-23 commented Apr 11, 2025

This PR is adding type of pageswap and pagereveal event callback args on window event handler property and addEventListener.
Both of them are already supported by Chromium and Webkit.

Note

PageSwap and PageReveal Event interfaces are added at this PR (microsoft/TypeScript#60987), but event handler callback args is still typed as Event.

Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.

@kyohei-23
Copy link
Contributor Author

@microsoft-github-policy-service agree

@saschanaz
Copy link
Contributor

LGTM, thanks!

Copy link
Contributor

There was an issue merging, maybe try again saschanaz. Details

@saschanaz
Copy link
Contributor

New changes require approval from someone other than the last pusher.

Hello @jakebailey, any idea about this new error?

@jakebailey
Copy link
Member

This is a new requirement for all Microsoft repos; PRs actually require approval from a maintainer. When the change happened and I didn't get pinged here, I assumed that things were still working okay. I guess not.

I can see if we can get an exception for this, but the only workaround I can see is to modify codeowner thing to have the bot approve the PR, which it cannot do as it's github-actions itself.

@saschanaz
Copy link
Contributor

Workarounds adding up, I'd like to see whether we can create a separate org for this repo.

@jakebailey
Copy link
Member

I'm working on a solution (which could involve something like that). In the meantime, absolutely feel free to ping me on PRs that you intend to merge; I'm terminally online enough that I'll see it and click the button.

@jakebailey jakebailey merged commit c9cadbb into microsoft:main Apr 11, 2025
6 of 7 checks passed
@kyohei-23 kyohei-23 deleted the add-viewtransition-events branch April 11, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants