Skip to content

Allow v5 as peerDependency in ata package #2977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 4, 2024
Merged

Conversation

curran
Copy link
Contributor

@curran curran commented Nov 15, 2023

One small step towards #2807

See comment #2807

Should in theory solve downstream issue vizhub-core/vzcode#352

Copy link
Contributor Author

@curran curran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing! I removed the upper bound.

@curran
Copy link
Contributor Author

curran commented Nov 15, 2023

CI failed.
image

It looks like I need to yarn install to update the lockfile, as part of the PR. Sorry about that!

@jakebailey jakebailey closed this Jun 2, 2024
@jakebailey jakebailey reopened this Jun 2, 2024
@curran
Copy link
Contributor Author

curran commented Jun 4, 2024

@microsoft-github-policy-service agree

@curran
Copy link
Contributor Author

curran commented Jun 4, 2024

Thanks for taking this over the finish line! Much appreciated.

@jakebailey jakebailey merged commit 7691811 into microsoft:v2 Jun 4, 2024
8 checks passed
@typescript-bot typescript-bot mentioned this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants