Skip to content

fix: ata return type #3002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 4, 2024
Merged

fix: ata return type #3002

merged 3 commits into from
Jun 4, 2024

Conversation

antfu
Copy link
Contributor

@antfu antfu commented Dec 17, 2023 •
edited
Loading

It actually returns a Promise. Would be nice to provide that info so users could await for it to resolve.

TypeScript-Website/packages/ata/src/index.ts

Lines 56 to 60 in c8b2ea8

return resolveDeps(initialSourceFile, 0).then(t => {
if (estimatedDownloaded > 0) {
config.delegate.finished?.(fsMap)
}
})

jakebailey
jakebailey approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but will require a package release.

@jakebailey jakebailey closed this Jun 2, 2024
@jakebailey jakebailey reopened this Jun 2, 2024
@jakebailey jakebailey merged commit fd776c0 into microsoft:v2 Jun 4, 2024
8 checks passed
@typescript-bot typescript-bot mentioned this pull request Jun 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orta orta orta approved these changes

@jakebailey jakebailey jakebailey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antfu @orta @jakebailey