Add milestone labels to PRs when related issues are milestoned #71
Conversation
| await run("Adding repro tags from issue bodies", addReprosLabelOnIssue) | ||
| await run("Adding milestone labels to related PRs", addMilestoneLabelsToRelatedPRs) |
There was a problem hiding this comment.
The promise was unawaited intentionally before; otherwise if the handler takes more than 10 seconds, the request will error out due to a timeout on GitHub's side of the webhook.
There was a problem hiding this comment.
what do u recommend then? those run actions are awaited in other webhooks so I followed suite here. Should this just kick off both "jobs"? Or maybe the old one should not be awaited but the new one should be awaited?
There was a problem hiding this comment.
Oh, they are? Weird.... Maybe we assume they're fast enough but I'd have to check the logs
| const houseKeepingLabels = { | ||
| "For Milestone Bug": false, | ||
| "For Backlog Bug": false, | ||
| }; |
There was a problem hiding this comment.
This all seems familiar; is the code not the same as addMilestoneLabelsToPRs?
There was a problem hiding this comment.
Yes, they are the same. They serve different purpose and I decided against unifying both places, it felt like an abstraction would hurt the readability here and this code is simple enough
This PR aims to add automation for scenarios when issues are milestoned after the fixing PR is already open.