Skip to content

Give better error message on consecutive numeric separators #20585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DanielRosenwasser opened this issue Dec 8, 2017 · 1 comment
Closed

Give better error message on consecutive numeric separators #20585

DanielRosenwasser opened this issue Dec 8, 2017 · 1 comment
Labels
Bug A bug in TypeScript Domain: Error Messages The issue relates to error messaging Fixed A PR has been merged for this issue Good First Issue Well scoped, documented and has the green light Help Wanted You can do this
Milestone
TypeScript 2.7

Comments

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Dec 8, 2017 •
edited
Loading

From #20324 (comment), and contingent on #20324 first getting merged.

let x = 123__456;

Note the double underscores.

Actual: Numeric separators are not allowed here.

  • A numeric literal cannot contain multiple consecutive separators.
  • Multiple consecutive numeric separators are not permitted.
@DanielRosenwasser DanielRosenwasser added Bug A bug in TypeScript Domain: Error Messages The issue relates to error messaging Good First Issue Well scoped, documented and has the green light Help Wanted You can do this labels Dec 8, 2017
@DanielRosenwasser DanielRosenwasser added this to the Community milestone Dec 8, 2017
harunurhan added a commit to harunurhan/TypeScript that referenced this issue Dec 9, 2017
@harunurhan
Better err msg on consecutive numeric separators
db4a470 
* Closes microsoft#20585
@harunurhan
Copy link
Member

harunurhan commented Dec 9, 2017 •
edited
Loading

I'll take this one as my first, if nobody else is working on it.

@YuichiNukiyama YuichiNukiyama mentioned this issue Dec 10, 2017
Merged
@mhegazy mhegazy modified the milestones: Community, TypeScript 2.7 Jan 11, 2018
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Jan 11, 2018
@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug A bug in TypeScript Domain: Error Messages The issue relates to error messaging Fixed A PR has been merged for this issue Good First Issue Well scoped, documented and has the green light Help Wanted You can do this
Projects
None yet
Milestone
TypeScript 2.7
Development

No branches or pull requests
3 participants
@DanielRosenwasser @harunurhan @mhegazy