skipLibCheck and exclude do not work under monorepos project

[WeijieZhu0204]

TypeScript Version: 3.8.3

Search Terms:

Code

// ./packages/visual-editor/tsconfig.json

{
  "compilerOptions": {
    "skipLibCheck": true,
    /* Basic Options */
    // "incremental": true,                   /* Enable incremental compilation */
    "target": "ESNEXT" /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', 'ES2018', 'ES2019' or 'ESNEXT'. */,
    "module": "commonjs" /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */,
    "lib": [
      "DOM",
      "ES2015",
      "ES2016",
      "ES2017",
      "ES2018"
    ] /* Specify library files to be included in the compilation. */,
    "allowJs": true /* Allow javascript files to be compiled. */,
    // "checkJs": true,                       /* Report errors in .js files. */
    "jsx": "preserve" /* Specify JSX code generation: 'preserve', 'react-native', or 'react'. */,
    // "declaration": true,                   /* Generates corresponding '.d.ts' file. */
    // "declarationMap": true,                /* Generates a sourcemap for each corresponding '.d.ts' file. */
    // "sourceMap": true,                     /* Generates corresponding '.map' file. */
    // "outFile": "./",                       /* Concatenate and emit output to single file. */
    // "outDir": "./",                        /* Redirect output structure to the directory. */
    // "rootDir": "./",                       /* Specify the root directory of input files. Use to control the output directory structure with --outDir. */
    // "composite": true,                     /* Enable project compilation */
    // "tsBuildInfoFile": "./",               /* Specify file to store incremental compilation information */
    // "removeComments": true,                /* Do not emit comments to output. */
    // "noEmit": true,                        /* Do not emit outputs. */
    // "importHelpers": true,                 /* Import emit helpers from 'tslib'. */
    // "downlevelIteration": true,            /* Provide full support for iterables in 'for-of', spread, and destructuring when targeting 'ES5' or 'ES3'. */
    // "isolatedModules": true,               /* Transpile each file as a separate module (similar to 'ts.transpileModule'). */

    /* Strict Type-Checking Options */
    "strict": true /* Enable all strict type-checking options. */,
    "noImplicitAny": true /* Raise error on expressions and declarations with an implied 'any' type. */,
    "strictNullChecks": true /* Enable strict null checks. */,
    // "strictFunctionTypes": true,           /* Enable strict checking of function types. */
    // "strictBindCallApply": true,           /* Enable strict 'bind', 'call', and 'apply' methods on functions. */
    // "strictPropertyInitialization": true,  /* Enable strict checking of property initialization in classes. */
    // "noImplicitThis": true,                /* Raise error on 'this' expressions with an implied 'any' type. */
    // "alwaysStrict": true,                  /* Parse in strict mode and emit "use strict" for each source file. */

    /* Additional Checks */
    // "noUnusedLocals": true,                /* Report errors on unused locals. */
    // "noUnusedParameters": true,            /* Report errors on unused parameters. */
    // "noImplicitReturns": true,             /* Report error when not all code paths in function return a value. */
    // "noFallthroughCasesInSwitch": true,    /* Report errors for fallthrough cases in switch statement. */

    /* Module Resolution Options */
    "moduleResolution": "node" /* Specify module resolution strategy: 'node' (Node.js) or 'classic' (TypeScript pre-1.6). */,
    "baseUrl": "./src",
    "paths": {
      "actions/*": ["./actions/*"],
      "apis/*": ["./apis/*"],
      "components/*": ["./components/*"],
      "constants/*": ["./constants/*"],
      "helpers/*": ["./helpers/*"],
      "hooks/*": ["./hooks/*"],
      "reducers/*": ["./reducers/*"],
      "types/*": ["./types/*"],
      "models/*": ["./models/*"]
    },
    // "rootDirs": [],                        /* List of root folders whose combined content represents the structure of the project at runtime. */
    // "typeRoots": [],                       /* List of folders to include type definitions from. */
    // "types": [],                           /* Type declaration files to be included in compilation. */
    // "allowSyntheticDefaultImports": true,  /* Allow default imports from modules with no default export. This does not affect code emit, just typechecking. */
    "esModuleInterop": true /* Enables emit interoperability between CommonJS and ES Modules via creation of namespace objects for all imports. Implies 'allowSyntheticDefaultImports'. */,
    // 与webpack resolve symlinks保持一致
    // "preserveSymlinks": true /* Do not resolve the real path of symlinks. */,
    // "allowUmdGlobalAccess": true,          /* Allow accessing UMD globals from modules. */

    /* Source Map Options */
    // "sourceRoot": "",                      /* Specify the location where debugger should locate TypeScript files instead of source locations. */
    // "mapRoot": "",                         /* Specify the location where debugger should locate map files instead of generated locations. */
    // "inlineSourceMap": true,               /* Emit a single file with source maps instead of having a separate file. */
    // "inlineSources": true,                 /* Emit the source alongside the sourcemaps within a single file; requires '--inlineSourceMap' or '--sourceMap' to be set. */

    /* Experimental Options */
    // "experimentalDecorators": true,        /* Enables experimental support for ES7 decorators. */
    // "emitDecoratorMetadata": true,         /* Enables experimental support for emitting type metadata for decorators. */

    /* Advanced Options */
    "forceConsistentCasingInFileNames": true /* Disallow inconsistently-cased references to the same file. */
  },
  "include": ["./src"],
  "exclude": ["node_modules"]
}

// list my project structure

├── lerna.json
├── node_modules
├── package.json
├── packages
│   ├── visual-editor
│   │   ├── dist
│   │   ├── example.config.js
│   │   ├── favicon.ico
│   │   ├── node_modules
│   │   ├── package.json
│   │   ├── readme.md
│   │   ├── src
│   │   ├── tsconfig.json
│   │   └── webpack.config.js
│   └── ....
├── readme.md
└── yarn.lock


// Execute tsc in the root directory of the project
tsc -p ./packages/visual-editor/tsconfig.json --noEmit --pretty

Expected behavior:
Hope that i can ignore the syntax check of the node_modules module through exclude and skipLibCheck configuration.But these configurations did not work.

Actual behavior:

Tsc throws errors about node_modules ,as follows :

Note : The @tencent/visual-material-wesing module was promoted to the root node_modules directory by lerna hosit.

9   extends BackgroundDataSetField,
            ~~~~~~~~~~~~~~~~~~~~~~

node_modules/@tencent/visual-material-wesing/src/components/head-module/head-module.tsx:10:5 - error TS2304: Cannot find name 'FontColorDataSetField'.

10     FontColorDataSetField,
       ~~~~~~~~~~~~~~~~~~~~~

node_modules/@tencent/visual-material-wesing/src/components/head-module/head-module.tsx:11:5 - error TS2304: Cannot find name 'PositionDataSetField'.

11     PositionDataSetField {
       ~~~~~~~~~~~~~~~~~~~~

node_modules/@tencent/visual-material-wesing/src/components/head-module/head-module.tsx:18:5 - error TS2339: Property 'top' does not exist on type 'Data'.

18     top,
       ~~~

node_modules/@tencent/visual-material-wesing/src/components/head-module/head-module.tsx:20:5 - error TS2339: Property 'left' does not exist on type 'Data'.

20     left,
       ~~~~

node_modules/@tencent/visual-material-wesing/src/components/head-module/head-module.tsx:21:5 - error TS2339: Property 'color' does not exist on type 'Data'.

21     color,
       ~~~~~

node_modules/@tencent/visual-material-wesing/src/components/head-module/head-module.tsx:23:5 - error TS2339: Property 'backgroundColor' does not exist on type 'Data'.

23     backgroundColor,
       ~~~~~~~~~~~~~~~

node_modules/@tencent/visual-material-wesing/src/components/head-module/head-module.tsx:24:5 - error TS2339: Property 'backgroundImage' does not exist on type 'Data'.

24     backgroundImage,
       ~~~~~~~~~~~~~~~

node_modules/@tencent/visual-material-wesing/src/components/head-module/head-module.tsx:25:5 - error TS2339: Property 'backgroundRepeat' does not exist on type 'Data'.

25     backgroundRepeat,
       ~~~~~~~~~~~~~~~~

node_modules/@tencent/visual-material-wesing/src/components/head-module/head-module.tsx:26:5 - error TS2339: Property 'backgroundSize' does not exist on type 'Data'.

26     backgroundSize,
       ~~~~~~~~~~~~~~

node_modules/@tencent/visual-material-wesing/src/components/ranking/definition.ts:12:34 - error TS2304: Cannot find name 'Theme'.

12 export const THEME_MAP = new Map<Theme, ThemeInfo>([
                                    ~~~~~

Playground Link:

Related Issues:

[abhijithvijayan]

I get these errors

error TS2403: Subsequent variable declarations must have the same type.

error TS2300: Duplicate identifier ...

in a yarn workspace monorepo.

The project root has a base configuration and the workspace folders have extended this configuration.

As a workaround, I had to set

  "compilerOptions": {
    // overrides
    "skipLibCheck": true
  },

in the root config file

[jsbroks]

Im running tsc in a monorepo with the --skipLibCheck and --listFiles flags, my output still contains node_module d.ts files.

...
/node_modules/aws-sdk/lib/credentials/shared_ini_file_credentials.d.ts
/node_modules/aws-sdk/lib/credentials/process_credentials.d.ts
/node_modules/aws-sdk/lib/credentials/temporary_credentials.d.ts
/node_modules/aws-sdk/lib/credentials/chainable_temporary_credentials.d.ts
/node_modules/aws-sdk/lib/credentials/web_identity_credentials.d.ts
/node_modules/aws-sdk/lib/credentials/token_file_web_identity_credentials.d.ts
...

Is this related?

[lukas1994]

Same issue here. It takes ages to load all the node_modules d.ts files.

[wzxinchen]

Same issue here. It takes ages to load all the node_modules d.ts files.

[PhilippMolitor]

Any update on this? This sadly is completely blocking any sort of builds for my projects.

[mizchi]

I have same error. I doubt .ts(x) under node_modules with skipLibCheck.

[uberbinge]

we are running into same issue after updating our aws-javascript-library to v3. Any pointers to how can we keep using new library and still be able to compile things?

[tylerthecoder]

Having the same issue. Blocking me on a bunch of projects. --listFiles shows .d.ts files in node_modules

[kamranayub]

Using explicit types helps greatly, we reduced monorepo build time by about 2X (with --skipLibCheck) by specifying types packages to load instead of letting tsc detect them within our monorepo.

[borekb]

I think that the example in the issue description is, at its core, #41883 – TypeScript does not apply skipLibCheck to .ts files – and note how all the example errors are from .ts(x) files:

9   extends BackgroundDataSetField,
            ~~~~~~~~~~~~~~~~~~~~~~

node_modules/@tencent/visual-material-wesing/src/components/head-module/head-module.tsx:10:5 - error TS2304: Cannot find name 'FontColorDataSetField'.

BTW we're not seeing issues like above that .d.ts would be included when we set skipLibCheck; that works reliably for us.

[ahtokca]

Same here, skipLibCheck is ignored and tsc checking files in node_modules folder

Any ideas how to solve it?

[elisalimli]

Same issue