Module resolution: NodeNext breaks typechecking #60561
Comments
|
I think we can also assume that as people will switch from tsx-like tools to the native nodejs flag to have typescript, the more we'll see this. |
|
The repo doesn't appear to be set up correctly? |
RyanCavanaugh
added
the
Needs More Info
|
@RyanCavanaugh sorry, I fixed it (a typo leftover from my cleanup to provide you the smallest repro as possible). |
|
Hey @RyanCavanaugh, have you guys had a chance to look into the repro? 
|
RyanCavanaugh
removed
the
Needs More Info
|
I don't see any file that looks like that in |
RyanCavanaugh
added
the
Needs More Info
|
Hi there, I did have the same issue with an import from I also created a little stackblitz to show the issue: https://stackblitz.com/edit/storyblok-js-client-typescript-issue. Investigating a bit, it seems like, that even if the imports are resolved correctly, typescript acts as if the package is a common js package. |
|
@leifmarcus the problem is in |
|
@RyanCavanaugh thank you very much! I didn’t know about the tool, you sent. appreciate. |
|
@RyanCavanaugh did you actually checkout the branch as I described in the issue report? git clone [email protected]:damianobarbati/ts-repro.git
cd ts-repro
git checkout typescript-constructable-issue
pnpm i
pnpm tscI just tested tsc again, and the problem is right there; in the real projects I'm working on, we have this on several libraries and we're just suppressing with @ts-ignore everywhere as we don't know how to properly solve this. $ pnpm tsc
> [email protected] tsc /Users/damians/Desktop/ts-repro
> tsc
services/api/src/index.ts:2:19 - error TS2351: This expression is not constructable.
Type 'typeof import("/Users/damians/Desktop/ts-repro/node_modules/.pnpm/[email protected]/node_modules/ioredis/built/index")' has no construct signatures.
2 const redis = new Redis();
~~~~~
Found 1 error in services/api/src/index.ts:2
ELIFECYCLE Command failed with exit code 1. |
RyanCavanaugh
added
Needs Investigation
|
Yeah, that does look wrong. It looks like the re-exported |
Demo Repo
https://github.com/damianobarbati/ts-repro
Which of the following problems are you reporting?
The module specifier resolves to the right file, but something about the types are wrong.
I'm using NodeNext to leverage the new node flag --transform-types.
Demonstrate the defect described above with a code sample.
To reproduce:
Here the line where this can be seen:
https://github.com/damianobarbati/ts-repro/blob/typescript-constructable-issue/services/api/src/index.ts#L2
Run
tsc --showConfigand paste its output here{ "compilerOptions": { "moduleResolution": "nodenext", "module": "nodenext", "target": "esnext", "lib": [ "dom", "dom.iterable", "esnext", "webworker" ], "allowJs": true, "allowImportingTsExtensions": true, "skipLibCheck": true, "strict": true, "forceConsistentCasingInFileNames": true, "noEmit": true, "noUnusedLocals": false, "esModuleInterop": true, "resolveJsonModule": true, "strictPropertyInitialization": false, "isolatedModules": true, "jsx": "preserve", "incremental": true, "baseUrl": "./", "tsBuildInfoFile": "../../../../tmp/tsbuildinfo", "moduleDetection": "force", "allowSyntheticDefaultImports": true, "resolvePackageJsonExports": true, "resolvePackageJsonImports": true, "preserveConstEnums": true, "useDefineForClassFields": true, "noImplicitAny": true, "noImplicitThis": true, "strictNullChecks": true, "strictFunctionTypes": true, "strictBindCallApply": true, "strictBuiltinIteratorReturn": true, "alwaysStrict": true, "useUnknownInCatchVariables": true }, "files": [ "./services/api/src/Foe.spec.ts", "./services/api/src/Foe.ts", "./services/api/src/index.ts", "./services/api/src/helper/fn.spec.ts", "./services/api/src/helper/fn.ts", "./services/types/src/User.spec.ts", "./services/types/src/User.ts" ] }Run
tsc --traceResolutionand paste its output herePaste the
package.jsonof the importing module, if it exists{ "name": "ioredis", "version": "5.6.0", "description": "A robust, performance-focused and full-featured Redis client for Node.js.", "main": "./built/index.js", "types": "./built/index.d.ts", "files": [ "built/" ], "scripts": { "test:tsd": "npm run build && tsd", "test:js": "TS_NODE_TRANSPILE_ONLY=true NODE_ENV=test mocha \"test/helpers/*.ts\" \"test/unit/**/*.ts\" \"test/functional/**/*.ts\"", "test:cov": "nyc npm run test:js", "test:js:cluster": "TS_NODE_TRANSPILE_ONLY=true NODE_ENV=test mocha \"test/cluster/**/*.ts\"", "test": "npm run test:js && npm run test:tsd", "lint": "eslint --ext .js,.ts ./lib", "docs": "npx typedoc --logLevel Error --excludeExternals --excludeProtected --excludePrivate --readme none lib/index.ts", "format": "prettier --write \"{,!(node_modules)/**/}*.{js,ts}\"", "format-check": "prettier --check \"{,!(node_modules)/**/}*.{js,ts}\"", "build": "rm -rf built && tsc", "prepublishOnly": "npm run build", "semantic-release": "semantic-release" }, "repository": { "type": "git", "url": "git://github.com/luin/ioredis.git" }, "keywords": [ "redis", "cluster", "sentinel", "pipelining" ], "tsd": { "directory": "test/typing" }, "author": "Zihua Li <[email protected]> (http://zihua.li)", "license": "MIT", "funding": { "type": "opencollective", "url": "https://opencollective.com/ioredis" }, "dependencies": { "@ioredis/commands": "^1.1.1", "cluster-key-slot": "^1.1.0", "debug": "^4.3.4", "denque": "^2.1.0", "lodash.defaults": "^4.2.0", "lodash.isarguments": "^3.1.0", "redis-errors": "^1.2.0", "redis-parser": "^3.0.0", "standard-as-callback": "^2.1.0" }, "devDependencies": { "@ioredis/interface-generator": "^1.3.0", "@semantic-release/changelog": "^6.0.1", "@semantic-release/commit-analyzer": "^9.0.2", "@semantic-release/git": "^10.0.1", "@types/chai": "^4.3.0", "@types/chai-as-promised": "^7.1.5", "@types/debug": "^4.1.5", "@types/lodash.defaults": "^4.2.7", "@types/lodash.isarguments": "^3.1.7", "@types/mocha": "^9.1.0", "@types/node": "^14.18.12", "@types/redis-errors": "^1.2.1", "@types/sinon": "^10.0.11", "@typescript-eslint/eslint-plugin": "^5.48.1", "@typescript-eslint/parser": "^5.48.1", "chai": "^4.3.6", "chai-as-promised": "^7.1.1", "eslint": "^8.31.0", "eslint-config-prettier": "^8.6.0", "mocha": "^9.2.1", "nyc": "^15.1.0", "prettier": "^2.6.1", "semantic-release": "^19.0.2", "server-destroy": "^1.0.1", "sinon": "^13.0.1", "ts-node": "^10.4.0", "tsd": "^0.19.1", "typedoc": "^0.22.18", "typescript": "^4.6.3", "uuid": "^9.0.0" }, "nyc": { "reporter": [ "lcov" ] }, "engines": { "node": ">=12.22.0" }, "mocha": { "exit": true, "timeout": 8000, "recursive": true, "require": "ts-node/register" } }Paste the
package.jsonof the target module, if it exists{ "name": "ts-repro", "author": "Damiano Barbati <[email protected]> (https://github.com/damianobarbati)", "repository": "https://github.com/damianobarbati/strip-types-repro", "license": "MIT", "version": "1.0.0", "description": "Native Typescript support / stripping.", "type": "module", "engines": { "node": ">=23" }, "scripts": { "lint": "biome check --write", "tsc": "tsc", "test": "vitest run" }, "devDependencies": { "@biomejs/biome": "^1.9.3", "typescript": "^5.8.2", "vitest": "^3.1.1" }, "dependencies": { "@types/node": "^22.13.16" } }Any other comments can go here
I'm using NodeNext to leverage the new node flag
--transform-types.The text was updated successfully, but these errors were encountered: