Invalid quick fix for function returning `Promise<unknown>` with `isolatedDeclarations`

[bradzacher]

🔎 Search Terms

isolatedDeclarations, quick fix, promise

🕗 Version & Regression Information

• This is the behavior in every version I tried

⏯ Playground Link

https://www.typescriptlang.org/play/?isolatedDeclarations=true#code/KYDwDg9gTgLgBAMwK4DsDGMCWEVwO4CGmMAqigNYR4oAUAtgM4BccKSdARsFAJRwDeAKDhwowGEii4UwPHAAKUCHUwNgNGnwC8APgEBfHgG5B+waEixEqDNlyFiAZRhRMKAOb1mrdl14DhUXFJaVkFJRU1AB4GFzd3HQ1tPX5DEzMgA

💻 Code

export function waitUnkown(ms: number) {
  return new Promise(() => {});
}
export function waitString(ms: number) {
  return new Promise<string>(() => {});
}

🙁 Actual behavior

The quick fix for waitUnknown is "Add return type Promise"

Which annotates the return type as : Promise -- which is a type error as the argument to the promise type is required.

🙂 Expected behavior

The quick fix for waitUnknown is "Add return type Promise", which is the correct, currently inferred type.

Additional information about the issue

I was trying to codemod Canva's codebase using ts-fix and this bug created a bunch of bad code which I would need to fix up by hand.

[AmitNaftali]

looks like solved in v5.9.0

[RyanCavanaugh]

Confirmed fixed in nightly