Skip to content

Fix tslint build #11447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Oct 7, 2016
Merged

Fix tslint build #11447

1 commit merged into from
Oct 7, 2016

Conversation

ghost
Copy link

@ghost ghost commented Oct 7, 2016

The build was broken due to passing a ModuleBlock into a function expecting a Block, as these types are now incompatible.

@ghost ghost force-pushed the visit_module_block branch from 9e8d94e to 731ce34 Compare October 7, 2016 15:25
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although the kludge looks like it's actually just updated. :)

@ghost ghost changed the title Remove kludge that appears to be unnecessary in newest tslint Fix tslint build Oct 7, 2016
@ghost ghost merged commit 49a6391 into master Oct 7, 2016
@ghost ghost deleted the visit_module_block branch October 7, 2016 15:35
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants