-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Set '.declarations' on a property of a homomorphic mapped type #16059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The change looks good but I'll wait to approve it until after the test failures are fixed to make sure there aren't any big changes that result. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test failures need another look.
…or properties; also update baselines
The bug in |
I'm not fluent with findAllRefs, so there may be an obvious answer: if a property or method is public, wouldn't it still need to be part of an exported type to be visible anywhere? |
True, but that would be hard to detect. |
OK, that's what I needed to know. I wasn't sure of |
|
Fixes #15821