organizeImports: Avoid using full FindAllReferences #22102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
amcasey
approved these changes
Feb 22, 2018
| @@ -709,6 +709,16 @@ namespace ts.FindAllReferences.Core { | |||
| return exposedByParent ? scope.getSourceFile() : scope; | |||
| } | |||
|
|
|||
| /** Used as a quick check for whether a symbol is used at all in a file (besides its definition). */ | |||
| export function isSymbolReferencedInFile(definition: Identifier, checker: TypeChecker, sourceFile: SourceFile) { | |||
There was a problem hiding this comment.
It probably wouldn't hurt to test this method.
src/services/organizeImports.ts
Outdated
| throwIfCancellationRequested: () => { /*noop*/ }, | ||
| }).filter(e => e.type === "node" && e.node.getSourceFile() === sourceFile); | ||
| return entries.length > 1; | ||
| return jsxContext && identifier.text === jsxNamespace || FindAllReferences.Core.isSymbolReferencedInFile(identifier, typeChecker, sourceFile); |
There was a problem hiding this comment.
Personally, I find it helpful to use parentheses when combining binary operators with different precedence.
|
FYI @mhegazy |
mhegazy
approved these changes
Feb 22, 2018
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For imports, all we really need is
getPossibleSymbolReferencePositionsfollowed by checking for exact symbol match. FindAllReferences would look for related symbols, but we don't actually want those in this case.