Add outlining spans for JSX elements #25329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhegazy
approved these changes
Jun 30, 2018
ghost
approved these changes
Jun 30, 2018
| return undefined; | ||
| } | ||
|
|
||
| return createOutliningSpanFromBounds(node.getStart(), node.getEnd(), OutliningSpanKind.Code); |
|
|
||
| function spanForJSXElement(node: JsxElement): OutliningSpan | undefined { | ||
| const textSpan = createTextSpanFromBounds(node.openingElement.getStart(), node.closingElement.getEnd()); | ||
| const tagName = node.openingElement.tagName.getText(); |
| } | ||
|
|
||
| function spanForJSXElement(node: JsxElement): OutliningSpan | undefined { | ||
| const textSpan = createTextSpanFromBounds(node.openingElement.getStart(), node.closingElement.getEnd()); |
There was a problem hiding this comment.
Nit: .getStart(sourceFile) for better performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23273 .
This PR adds outlining regions for JSX elements in two ways:
For JSX elements (with an opening tag and a closing tag), we provide an outlining region that spans the whole element. This matches the behavior in Visual Studio for HTML files. When collapsed, the text
<tagname>…</tagname>is shown, regardless of attributes.For JSX opening elements (including self-closing elements), we provide an outlining region that spans the attributes. This allows tags with multiple lines of attributes to be collapsed.