Skip to content

fix(36102): fix extra new line in Organize Imports #36911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2020

Conversation

sacgrover
Copy link
Contributor

Organize Imports was inserting extra newline.

Fixes #36102

@sandersn sandersn added the For Milestone Bug PRs that fix a bug with a specific milestone label Mar 2, 2020
@sandersn sandersn requested a review from elibarzilay March 2, 2020 20:15
@sandersn
Copy link
Member

sandersn commented Mar 2, 2020

@elibarzilay mind taking a look at this PR?

@sandersn
Copy link
Member

sandersn commented Mar 2, 2020

@andrewbranch is this related to #36688 ?

@andrewbranch
Copy link
Member

It is not.

Copy link
Contributor

@elibarzilay elibarzilay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another thing is to add tests (but TBH when I looked at that the tests I've seen compare lists of imports rather than the generated text).

Organize Imports was inserting extra newline.

Fixes microsoft#36102
@elibarzilay elibarzilay merged commit bff0ddc into microsoft:master Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Milestone Bug PRs that fix a bug with a specific milestone
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

TypeScript Organize Imports inserts extra newline
5 participants