Skip to content

Fix indentation of multiline conditional expressions #42484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 29, 2021

Conversation

andrewbranch
Copy link
Member

Fixes #40854

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Jan 25, 2021
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with your teams discussion about this code -- the architecture causes you to write rules backward from the way that they should be specified. The amount of commenting you wrote is an indicator of that.

Co-authored-by: Nathan Shively-Sanders <[email protected]>
@andrewbranch andrewbranch merged commit 9d21a5b into microsoft:master Jan 29, 2021
@andrewbranch andrewbranch deleted the bug/40854 branch January 29, 2021 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong TSX ternary markup block formatting on save
3 participants