Skip to content

Use shared binary trampoline in checker #43035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2021
Merged

Use shared binary trampoline in checker #43035

merged 1 commit into from
Mar 20, 2021

Conversation

rbuckton
Copy link
Member

@rbuckton rbuckton commented Mar 2, 2021

Migrates the checker to use the shared binary trampoline added in #42676

@rbuckton rbuckton requested a review from weswigham March 2, 2021 02:15
@rbuckton
Copy link
Member Author

rbuckton commented Mar 2, 2021

@typescript-bot perf test

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 2, 2021 •
edited
Loading

Heya @rbuckton, I've started to run the perf test suite on this PR at c450425. You can monitor the build here.

Update: The results are in!

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Mar 2, 2021
@typescript-bot
Copy link
Collaborator

@rbuckton
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..43035

Metric master 43035 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 349,185k (± 0.02%) 349,197k (± 0.01%) +12k (+ 0.00%) 349,073k 349,293k
Parse Time 1.92s (± 0.78%) 1.92s (± 0.43%) -0.01s (- 0.26%) 1.90s 1.93s
Bind Time 0.83s (± 0.71%) 0.83s (± 0.71%) 0.00s ( 0.00%) 0.82s 0.85s
Check Time 5.04s (± 0.68%) 5.06s (± 0.50%) +0.02s (+ 0.36%) 4.99s 5.11s
Emit Time 5.70s (± 0.74%) 5.65s (± 0.62%) -0.05s (- 0.88%) 5.56s 5.71s
Total Time 13.49s (± 0.52%) 13.45s (± 0.31%) -0.04s (- 0.27%) 13.40s 13.55s
Compiler-Unions - node (v10.16.3, x64)
Memory used 204,226k (± 0.02%) 204,233k (± 0.03%) +7k (+ 0.00%) 204,091k 204,323k
Parse Time 0.78s (± 1.00%) 0.78s (± 0.77%) -0.00s (- 0.51%) 0.77s 0.79s
Bind Time 0.52s (± 0.77%) 0.52s (± 1.00%) -0.00s (- 0.38%) 0.51s 0.53s
Check Time 7.38s (± 0.52%) 7.44s (± 0.59%) +0.05s (+ 0.68%) 7.31s 7.54s
Emit Time 2.54s (± 0.82%) 2.54s (± 0.87%) -0.01s (- 0.28%) 2.48s 2.57s
Total Time 11.23s (± 0.35%) 11.26s (± 0.50%) +0.03s (+ 0.29%) 11.09s 11.37s
Monaco - node (v10.16.3, x64)
Memory used 356,530k (± 0.02%) 356,589k (± 0.02%) +59k (+ 0.02%) 356,408k 356,720k
Parse Time 1.56s (± 0.39%) 1.55s (± 0.69%) -0.00s (- 0.26%) 1.52s 1.57s
Bind Time 0.74s (± 0.88%) 0.74s (± 1.11%) -0.00s (- 0.14%) 0.72s 0.75s
Check Time 5.21s (± 0.49%) 5.23s (± 0.47%) +0.02s (+ 0.33%) 5.18s 5.28s
Emit Time 3.11s (± 0.86%) 3.08s (± 0.65%) -0.02s (- 0.80%) 3.05s 3.14s
Total Time 10.61s (± 0.48%) 10.60s (± 0.40%) -0.01s (- 0.14%) 10.54s 10.69s
TFS - node (v10.16.3, x64)
Memory used 308,909k (± 0.02%) 308,933k (± 0.04%) +24k (+ 0.01%) 308,757k 309,336k
Parse Time 1.20s (± 0.96%) 1.21s (± 0.62%) +0.00s (+ 0.17%) 1.19s 1.22s
Bind Time 0.69s (± 0.75%) 0.70s (± 0.47%) +0.01s (+ 1.30%) 0.69s 0.71s
Check Time 4.64s (± 0.60%) 4.70s (± 0.58%) +0.05s (+ 1.18%) 4.63s 4.75s
Emit Time 3.21s (± 1.19%) 3.23s (± 1.26%) +0.02s (+ 0.69%) 3.15s 3.33s
Total Time 9.74s (± 0.52%) 9.83s (± 0.58%) +0.09s (+ 0.90%) 9.68s 9.99s
material-ui - node (v10.16.3, x64)
Memory used 502,159k (± 0.01%) 502,160k (± 0.01%) +1k (+ 0.00%) 502,054k 502,329k
Parse Time 1.99s (± 0.67%) 1.98s (± 0.52%) -0.00s (- 0.15%) 1.97s 2.01s
Bind Time 0.65s (± 0.99%) 0.65s (± 1.02%) -0.00s (- 0.31%) 0.64s 0.66s
Check Time 14.18s (± 0.52%) 14.15s (± 0.38%) -0.03s (- 0.23%) 14.02s 14.28s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 16.82s (± 0.44%) 16.78s (± 0.31%) -0.04s (- 0.23%) 16.65s 16.89s
Angular - node (v12.1.0, x64)
Memory used 326,640k (± 0.09%) 326,856k (± 0.03%) +216k (+ 0.07%) 326,583k 327,087k
Parse Time 1.91s (± 0.61%) 1.90s (± 0.53%) -0.01s (- 0.47%) 1.88s 1.92s
Bind Time 0.81s (± 0.55%) 0.81s (± 1.12%) +0.00s (+ 0.37%) 0.80s 0.83s
Check Time 4.93s (± 0.86%) 4.96s (± 0.29%) +0.03s (+ 0.59%) 4.94s 5.00s
Emit Time 5.73s (± 1.04%) 5.68s (± 0.50%) -0.05s (- 0.96%) 5.62s 5.75s
Total Time 13.38s (± 0.70%) 13.35s (± 0.28%) -0.03s (- 0.24%) 13.26s 13.44s
Compiler-Unions - node (v12.1.0, x64)
Memory used 190,772k (± 0.08%) 190,748k (± 0.07%) -24k (- 0.01%) 190,381k 190,997k
Parse Time 0.77s (± 0.84%) 0.76s (± 0.62%) -0.01s (- 1.04%) 0.75s 0.77s
Bind Time 0.53s (± 0.69%) 0.52s (± 1.11%) -0.01s (- 1.14%) 0.51s 0.53s
Check Time 6.96s (± 0.75%) 6.95s (± 0.66%) -0.01s (- 0.13%) 6.87s 7.10s
Emit Time 2.53s (± 0.71%) 2.51s (± 0.74%) -0.02s (- 0.83%) 2.47s 2.54s
Total Time 10.78s (± 0.40%) 10.74s (± 0.55%) -0.04s (- 0.40%) 10.64s 10.93s
Monaco - node (v12.1.0, x64)
Memory used 339,015k (± 0.01%) 339,035k (± 0.02%) +20k (+ 0.01%) 338,904k 339,243k
Parse Time 1.54s (± 0.63%) 1.53s (± 0.82%) -0.01s (- 0.52%) 1.51s 1.56s
Bind Time 0.72s (± 0.72%) 0.72s (± 0.81%) -0.00s (- 0.28%) 0.71s 0.73s
Check Time 5.01s (± 0.43%) 5.06s (± 0.34%) +0.05s (+ 0.94%) 5.01s 5.08s
Emit Time 3.07s (± 0.71%) 3.07s (± 0.87%) -0.00s (- 0.00%) 3.01s 3.13s
Total Time 10.33s (± 0.41%) 10.37s (± 0.40%) +0.04s (+ 0.38%) 10.29s 10.46s
TFS - node (v12.1.0, x64)
Memory used 293,064k (± 0.01%) 293,036k (± 0.01%) -28k (- 0.01%) 292,925k 293,102k
Parse Time 1.22s (± 0.96%) 1.21s (± 0.73%) -0.01s (- 0.49%) 1.20s 1.24s
Bind Time 0.68s (± 0.87%) 0.69s (± 1.60%) +0.01s (+ 0.73%) 0.67s 0.73s
Check Time 4.59s (± 0.50%) 4.63s (± 0.41%) +0.04s (+ 0.92%) 4.57s 4.66s
Emit Time 3.10s (± 0.76%) 3.11s (± 0.51%) +0.01s (+ 0.23%) 3.08s 3.16s
Total Time 9.59s (± 0.38%) 9.64s (± 0.33%) +0.05s (+ 0.49%) 9.58s 9.72s
material-ui - node (v12.1.0, x64)
Memory used 480,122k (± 0.01%) 480,033k (± 0.01%) -89k (- 0.02%) 479,924k 480,133k
Parse Time 2.00s (± 0.47%) 1.99s (± 0.38%) -0.02s (- 0.85%) 1.97s 2.00s
Bind Time 0.64s (± 0.81%) 0.64s (± 1.10%) -0.00s (- 0.31%) 0.62s 0.65s
Check Time 12.79s (± 0.61%) 12.79s (± 0.51%) 0.00s ( 0.00%) 12.68s 12.98s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.44s (± 0.54%) 15.42s (± 0.45%) -0.02s (- 0.10%) 15.31s 15.62s
Angular - node (v14.15.1, x64)
Memory used 325,484k (± 0.01%) 325,521k (± 0.01%) +37k (+ 0.01%) 325,470k 325,554k
Parse Time 1.90s (± 0.43%) 1.91s (± 0.64%) +0.01s (+ 0.42%) 1.89s 1.94s
Bind Time 0.86s (± 0.81%) 0.86s (± 0.85%) -0.00s (- 0.35%) 0.84s 0.87s
Check Time 4.91s (± 0.45%) 4.96s (± 0.40%) +0.04s (+ 0.90%) 4.91s 4.99s
Emit Time 5.94s (± 0.53%) 5.97s (± 0.36%) +0.03s (+ 0.57%) 5.93s 6.02s
Total Time 13.62s (± 0.32%) 13.70s (± 0.34%) +0.09s (+ 0.65%) 13.59s 13.79s
Compiler-Unions - node (v14.15.1, x64)
Memory used 190,590k (± 0.01%) 190,613k (± 0.01%) +23k (+ 0.01%) 190,566k 190,716k
Parse Time 0.80s (± 0.70%) 0.79s (± 0.47%) -0.00s (- 0.38%) 0.79s 0.80s
Bind Time 0.56s (± 0.67%) 0.55s (± 0.81%) -0.00s (- 0.54%) 0.54s 0.56s
Check Time 6.99s (± 0.43%) 7.01s (± 0.39%) +0.01s (+ 0.20%) 6.95s 7.07s
Emit Time 2.52s (± 0.75%) 2.50s (± 0.80%) -0.02s (- 0.87%) 2.47s 2.57s
Total Time 10.86s (± 0.35%) 10.86s (± 0.34%) -0.01s (- 0.06%) 10.78s 10.92s
Monaco - node (v14.15.1, x64)
Memory used 337,996k (± 0.01%) 338,025k (± 0.01%) +29k (+ 0.01%) 337,961k 338,055k
Parse Time 1.56s (± 0.61%) 1.55s (± 0.44%) -0.00s (- 0.19%) 1.54s 1.57s
Bind Time 0.74s (± 0.60%) 0.74s (± 0.66%) +0.00s (+ 0.27%) 0.74s 0.76s
Check Time 4.95s (± 0.36%) 4.98s (± 0.48%) +0.04s (+ 0.77%) 4.94s 5.04s
Emit Time 3.12s (± 0.64%) 3.10s (± 0.49%) -0.01s (- 0.45%) 3.07s 3.14s
Total Time 10.37s (± 0.30%) 10.38s (± 0.31%) +0.02s (+ 0.15%) 10.33s 10.45s
TFS - node (v14.15.1, x64)
Memory used 292,202k (± 0.01%) 292,218k (± 0.01%) +17k (+ 0.01%) 292,175k 292,277k
Parse Time 1.25s (± 1.97%) 1.25s (± 1.18%) -0.00s (- 0.16%) 1.22s 1.29s
Bind Time 0.71s (± 0.67%) 0.71s (± 0.81%) 0.00s ( 0.00%) 0.70s 0.73s
Check Time 4.56s (± 0.47%) 4.65s (± 0.46%) +0.09s (+ 1.93%) 4.60s 4.71s
Emit Time 3.19s (± 0.30%) 3.20s (± 0.51%) +0.01s (+ 0.44%) 3.17s 3.24s
Total Time 9.72s (± 0.33%) 9.82s (± 0.30%) +0.10s (+ 1.03%) 9.73s 9.86s
material-ui - node (v14.15.1, x64)
Memory used 478,541k (± 0.00%) 478,506k (± 0.00%) -35k (- 0.01%) 478,464k 478,533k
Parse Time 2.06s (± 0.88%) 2.04s (± 0.53%) -0.02s (- 1.02%) 2.02s 2.06s
Bind Time 0.69s (± 0.68%) 0.70s (± 0.68%) +0.01s (+ 1.01%) 0.68s 0.70s
Check Time 12.85s (± 0.30%) 12.90s (± 0.54%) +0.05s (+ 0.37%) 12.80s 13.13s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.61s (± 0.32%) 15.64s (± 0.42%) +0.03s (+ 0.22%) 15.54s 15.85s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-198-generic
Architecturex64
Available Memory16 GB
Available Memory5 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v10.16.3, x64)
  • Compiler-Unions - node (v12.1.0, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v14.15.1, x64)
Benchmark Name Iterations
Current 43035 10
Baseline master 10

Developer Information:

Download Benchmark

@sandersn
Copy link
Member

@rbuckton Is this ready to merge or is it waiting on some additional validation?

@rbuckton rbuckton merged commit 9af313d into master Mar 20, 2021
@rbuckton rbuckton deleted the checkerBinaryTrampoline branch March 20, 2021 01:54
rbuckton added a commit that referenced this pull request Mar 20, 2021
@rbuckton
Accepts baseline change caused by #43035
e8ac484
rbuckton added a commit that referenced this pull request Mar 21, 2021
@rbuckton
Accepts baseline change caused by #43035 (#43322)
03bf732
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weswigham weswigham weswigham approved these changes

Assignees

@rbuckton rbuckton

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rbuckton @typescript-bot @sandersn @weswigham