Make export-module and reference maps invertible #44402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
|
The code's a bit rough, but I thought I should post something before our discussion. I'll add perf numbers shortly. |
|
For a small fraction of the original repro Before: (The anonymous functions are the lambdas in After |
|
To validate, I traced the path argument to every |
|
Force push is a rebase. |
|
@typescript-bot perf test this |
|
Heya @amcasey, I've started to run the perf test suite on this PR at eef8705. You can monitor the build here. Update: The results are in! |
|
I'm pretty sure we have no perf suite coverage of the builder, but why not? |
amcasey
commented
Jun 3, 2021
| @@ -546,70 +549,59 @@ namespace ts { | |||
| } | |||
|
|
|||
| Debug.assert(!!state.currentAffectedFilesExportedModulesMap); | |||
|
|
|||
| const seenFileAndExportsOfFile = new Set<string>(); | |||
There was a problem hiding this comment.
Separate PR: @sheetalkamat can we lift this out a couple levels so we don't revisit the same paths repeatedly for different "affected" files?
There was a problem hiding this comment.
Or maybe it belongs on the state?
There was a problem hiding this comment.
To share it across more than one affected file, it would have to be on the state. I'm going to try updating it in parallel with seenAffectedFiles.
There was a problem hiding this comment.
Assuming I've done it correctly, it saves about 10% of total time. Nothing to complain about, but much less than this change.
amcasey
commented
Jun 3, 2021
| forEachEntry(state.exportedModulesMap, (exportedModules, exportedFromPath) => | ||
| !state.currentAffectedFilesExportedModulesMap!.has(exportedFromPath) && // If we already iterated this through cache, ignore it | ||
| exportedModules.has(affectedFile.resolvedPath) && | ||
| state.exportedModulesMap.getKeys(affectedFile.resolvedPath)?.forEach(exportedFromPath => |
There was a problem hiding this comment.
I couldn't find a place where exportedModulesMap was consumed "forward", but it's maintained forward and I couldn't see a way to reverse the meaning without making maintenance (specifically, deleting paths) really expensive.
amcasey
commented
Jun 3, 2021
|
@amcasey Here they are:Comparison Report - master..44402
System
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
I claim the material-ui check time regression is from another change because the builder (which I don't believe runs in that perf test) doesn't count towards check time. |
|
@amcasey, if you want a project that has egregious issues with builder performance, we have one that repros issues fairly regularly (I've seen >30 minutes spent in the stage of determining what files are affected before). I expect it is largely due to the ~2500 files that are in a circular dependency snarl. |
|
@typescript-bot pack this |
|
@dmichon-msft Cool! Do you mind giving it a spin? You'll probably want to set |
sheetalkamat
requested changes
Jun 8, 2021
Right now, we're enumerating all the entries to find out which keys map to a corresponding value. By maintaining a two-way map, we can convert this linear search into a map lookup and skip allocation of many, many iterator results.
|
Force push is a rebase. |
andrewbranch
approved these changes
Jun 17, 2021
|
I've re-verified that a trace of the traversals matches the pre-change version. |
amcasey
commented
Jul 29, 2021
| @@ -311,7 +313,7 @@ namespace ts { | |||
| newState.affectedFilesIndex = state.affectedFilesIndex; | |||
| newState.currentChangedFilePath = state.currentChangedFilePath; | |||
| newState.currentAffectedFilesSignatures = state.currentAffectedFilesSignatures && new Map(state.currentAffectedFilesSignatures); | |||
| newState.currentAffectedFilesExportedModulesMap = state.currentAffectedFilesExportedModulesMap && new Map(state.currentAffectedFilesExportedModulesMap); | |||
There was a problem hiding this comment.
@andrewbranch I retained the existing behavior but, now that I look at it, it seems wrong. The value type of this map is a set - doesn't that mean that the new and old maps will refer to (and modify) the same sets? It seems like the intention was probably to do a deep copy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, we're enumerating all the entries to find out which keys map
to a corresponding value. By maintaining a two-way map, we can convert
this linear search into a map lookup and skip allocation of many, many
iterator results.