check usage before declaration for decorators #50372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zzzen
commented
Aug 19, 2022
src/compiler/checker.ts
Outdated
| return !!findAncestor(usage, current => { | ||
| if (current === declContainer) { | ||
| return "quit"; | ||
| } | ||
| if (isFunctionLike(current)) { | ||
| return true; | ||
| return !getImmediatelyInvokedFunctionExpression(current); |
There was a problem hiding this comment.
Enum is not checked properly. playground
function foo17() {
let a = (() => Enum.Yes)(); // should error
enum Enum {
No = 0,
Yes = 1,
}
}
foo17()
|
@typescript-bot test this |
|
Heya @DanielRosenwasser, I've started to run the extended test suite on this PR at 4190fb8. You can monitor the build here. |
|
Heya @DanielRosenwasser, I've started to run the diff-based user code test suite on this PR at 4190fb8. You can monitor the build here. Update: The results are in! |
|
Heya @DanielRosenwasser, I've started to run the perf test suite on this PR at 4190fb8. You can monitor the build here. Update: The results are in! |
|
@DanielRosenwasser Here are the results of running the user test suite comparing Everything looks good! |
|
Heya @DanielRosenwasser, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here. |
|
@DanielRosenwasser Here they are:
CompilerComparison Report - main..50372
System
Hosts
Scenarios
TSServerComparison Report - main..50372
System
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
@typescript-bot test this |
|
@sandersn Here are the results of running the user tests with tsc comparing There were infrastructure failures potentially unrelated to your change:
Otherwise... Everything looks good! |
|
Hey @sandersn, the results of running the DT tests are ready. Everything looks the same! |
|
@sandersn Here they are:
tscComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
@sandersn Here are the results of running the top 400 repos with tsc comparing Everything looks good! |
sandersn
approved these changes
May 2, 2025
gabritto
approved these changes
May 2, 2025
github-project-automation
bot
moved this from Waiting on reviewers
to Needs merge
in PR Backlog
1 task
|
|
|
I'm confused; wouldn't our extended tests have caught a bad break? |
|
Actually, my read is wrong. #57933 only applied to passing the declared class variable to decorators used within that class, which is kosher given that the transformer injects the decorator call after the class is declared. The example from #62083, passing a block-scoped variable declared after the class to a decorator within the class body, would lead to runtime errors if transpiled by TypeScript itself – clearly the custom transpilation used there is doing something different. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50349