Skip to content

Bump minimum Node to 14.17, ES to 2020 for TS 5.1 #53291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 15, 2023
Merged

Bump minimum Node to 14.17, ES to 2020 for TS 5.1 #53291

merged 4 commits into from
Apr 15, 2023

Conversation

jakebailey
Copy link
Member

The minimum of TS 5.0 is Node 12.20, which has been EOL for about a year.

Per #53198, our "policy" is to try and support the previous EOL version, which will shortly become Node 14, before TS 5.1 is out.

This PR bumps our minimum Node version to Node 14.17, the first Node 14 release with stable ESM, as well as bumps our lib target to ES2020.

The esbuild config cannot be just ES2020, as it turns out that Node 14 only partially supports some ES2020 features. Notably, optional chaining has some broken edge cases which were not fixed until Node 16.1. See: evanw/esbuild#2940

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 16, 2023
jakebailey
jakebailey commented Mar 16, 2023
View reviewed changes
src/tsconfig-base.json
"lib": ["es2018"],
"target": "es2018",
"lib": ["es2020"],
"target": "es2020",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this should be set to ES2019 to be safe about the Node 14 problems.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I set these to es2019 in an abundance of caution.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though, that feels inconsistent :(

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just flipped it back. We'll k now if we have to do it but since we aren't using this output anyway I don't think the inconsistency is a good idea.

@jakebailey
Copy link
Member Author

jakebailey commented Mar 16, 2023 •
edited
Loading

I could also back this down to Node 14.13, which is to Node 12.20 as Node 14.17 is to Node 12.22.

Or, Node 14.18, for node: requires.

https://nodejs.org/api/esm.html

@jakebailey
Copy link
Member Author

14.17 seems like the best bet; if we were to use glob v9 (which, I may send a PR for), that's its minimum.

@sandersn
Copy link
Member

Silly question: does this PR change performance, since our emitted code could change to be closer to the source?

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 27, 2023 •
edited
Loading

Heya @sandersn, I've started to run the perf test suite on this PR at 83e6114. You can monitor the build here.

Update: The results are in!

@jakebailey
Copy link
Member Author

jakebailey commented Mar 27, 2023 •
edited
Loading

Silly question: does this PR change performance, since our emitted code could change to be closer to the source?

No, unfortunately the only new syntax we gain is optional catch bindings. We don't get ?. or ?? and stuff because it was broken in Node 14.

We could just as easily just leave es2018 and be fine.

@typescript-bot
Copy link
Collaborator

@sandersn
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..53291
Metric main 53291 Delta Best Worst p-value
Angular - node (v18.10.0, x64)
Memory used 362,322k (± 0.01%) 362,306k (± 0.01%) ~ 362,277k 362,336k p=0.423 n=6
Parse Time 3.35s (± 0.61%) 3.35s (± 0.64%) ~ 3.32s 3.38s p=1.000 n=6
Bind Time 1.11s (± 0.73%) 1.11s (± 0.37%) ~ 1.10s 1.11s p=0.206 n=6
Check Time 8.65s (± 0.37%) 8.63s (± 0.52%) ~ 8.58s 8.70s p=0.520 n=6
Emit Time 7.43s (± 0.34%) 7.44s (± 0.54%) ~ 7.38s 7.49s p=0.468 n=6
Total Time 20.54s (± 0.19%) 20.54s (± 0.43%) ~ 20.39s 20.63s p=0.936 n=6
Compiler-Unions - node (v18.10.0, x64)
Memory used 193,638k (± 1.61%) 190,801k (± 0.03%) ~ 190,709k 190,838k p=0.423 n=6
Parse Time 1.48s (± 1.63%) 1.48s (± 1.60%) ~ 1.45s 1.50s p=1.000 n=6
Bind Time 0.77s (± 0.82%) 0.77s (± 0.72%) ~ 0.76s 0.77s p=0.201 n=6
Check Time 9.62s (± 0.68%) 9.62s (± 0.96%) ~ 9.53s 9.78s p=1.000 n=6
Emit Time 2.74s (± 0.71%) 2.72s (± 0.28%) -0.02s (- 0.73%) 2.71s 2.73s p=0.046 n=6
Total Time 14.61s (± 0.31%) 14.59s (± 0.70%) ~ 14.49s 14.78s p=0.336 n=6
Monaco - node (v18.10.0, x64)
Memory used 346,442k (± 0.01%) 346,429k (± 0.01%) ~ 346,384k 346,454k p=0.873 n=6
Parse Time 2.58s (± 0.97%) 2.57s (± 1.00%) ~ 2.54s 2.61s p=0.466 n=6
Bind Time 1.00s (± 0.83%) 1.00s (± 0.98%) ~ 0.99s 1.02s p=0.445 n=6
Check Time 7.11s (± 0.47%) 7.11s (± 0.54%) ~ 7.06s 7.17s p=0.810 n=6
Emit Time 4.27s (± 0.75%) 4.20s (± 0.50%) -0.07s (- 1.64%) 4.17s 4.23s p=0.006 n=6
Total Time 14.97s (± 0.45%) 14.88s (± 0.29%) -0.09s (- 0.62%) 14.83s 14.93s p=0.043 n=6
TFS - node (v18.10.0, x64)
Memory used 300,659k (± 0.00%) 300,668k (± 0.00%) ~ 300,650k 300,683k p=0.228 n=6
Parse Time 2.05s (± 0.65%) 2.05s (± 0.91%) ~ 2.02s 2.07s p=1.000 n=6
Bind Time 1.14s (± 0.66%) 1.13s (± 0.91%) ~ 1.12s 1.15s p=0.155 n=6
Check Time 6.53s (± 0.58%) 6.55s (± 0.44%) ~ 6.53s 6.61s p=0.374 n=6
Emit Time 3.85s (± 0.84%) 3.85s (± 1.24%) ~ 3.79s 3.93s p=0.871 n=6
Total Time 13.57s (± 0.41%) 13.58s (± 0.33%) ~ 13.52s 13.65s p=0.572 n=6
material-ui - node (v18.10.0, x64)
Memory used 477,111k (± 0.01%) 477,150k (± 0.01%) ~ 477,084k 477,233k p=0.297 n=6
Parse Time 3.01s (± 2.28%) 2.99s (± 2.88%) ~ 2.91s 3.08s p=0.872 n=6
Bind Time 0.95s (± 6.98%) 0.99s (± 9.27%) ~ 0.90s 1.08s p=0.514 n=6
Check Time 17.18s (± 0.62%) 17.14s (± 0.60%) ~ 17.06s 17.34s p=0.575 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 21.13s (± 0.46%) 21.13s (± 0.48%) ~ 21.05s 21.32s p=0.688 n=6
xstate - node (v18.10.0, x64)
Memory used 552,886k (± 0.03%) 552,902k (± 0.02%) ~ 552,776k 553,062k p=0.936 n=6
Parse Time 3.78s (± 0.60%) 3.76s (± 0.49%) ~ 3.74s 3.78s p=0.461 n=6
Bind Time 1.67s (± 0.50%) 1.66s (± 0.59%) ~ 1.65s 1.67s p=0.256 n=6
Check Time 2.84s (± 0.74%) 2.84s (± 0.99%) ~ 2.81s 2.89s p=0.624 n=6
Emit Time 0.08s (± 0.00%) 0.08s (± 0.00%) ~ 0.08s 0.08s p=1.000 n=6
Total Time 8.37s (± 0.42%) 8.34s (± 0.54%) ~ 8.29s 8.41s p=0.327 n=6
Angular - node (v16.17.1, x64)
Memory used 361,672k (± 0.01%) 361,679k (± 0.00%) ~ 361,661k 361,700k p=0.873 n=6
Parse Time 3.52s (± 0.59%) 3.51s (± 0.43%) ~ 3.49s 3.53s p=1.000 n=6
Bind Time 1.18s (± 0.69%) 1.18s (± 0.76%) ~ 1.17s 1.19s p=0.550 n=6
Check Time 9.49s (± 0.40%) 9.50s (± 0.61%) ~ 9.43s 9.59s p=0.808 n=6
Emit Time 7.94s (± 0.43%) 7.94s (± 0.49%) ~ 7.89s 7.99s p=0.935 n=6
Total Time 22.12s (± 0.35%) 22.14s (± 0.35%) ~ 22.02s 22.24s p=0.809 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used 193,633k (± 0.87%) 192,514k (± 0.04%) ~ 192,453k 192,647k p=0.066 n=6
Parse Time 1.59s (± 0.52%) 1.59s (± 0.93%) ~ 1.56s 1.60s p=0.383 n=6
Bind Time 0.82s (± 0.92%) 0.83s (± 0.66%) ~ 0.82s 0.83s p=0.137 n=6
Check Time 10.28s (± 0.73%) 10.29s (± 0.42%) ~ 10.25s 10.36s p=0.936 n=6
Emit Time 3.01s (± 0.64%) 3.00s (± 1.26%) ~ 2.97s 3.05s p=0.629 n=6
Total Time 15.70s (± 0.50%) 15.71s (± 0.39%) ~ 15.63s 15.78s p=0.873 n=6
Monaco - node (v16.17.1, x64)
Memory used 345,742k (± 0.01%) 345,728k (± 0.00%) ~ 345,715k 345,741k p=0.173 n=6
Parse Time 2.71s (± 0.60%) 2.72s (± 0.71%) ~ 2.69s 2.74s p=0.289 n=6
Bind Time 1.09s (± 1.11%) 1.08s (± 0.70%) ~ 1.07s 1.09s p=0.652 n=6
Check Time 7.80s (± 0.50%) 7.79s (± 0.69%) ~ 7.75s 7.90s p=0.629 n=6
Emit Time 4.45s (± 0.59%) 4.45s (± 0.62%) ~ 4.41s 4.47s p=0.808 n=6
Total Time 16.05s (± 0.39%) 16.04s (± 0.23%) ~ 16.00s 16.11s p=1.000 n=6
TFS - node (v16.17.1, x64)
Memory used 300,014k (± 0.01%) 300,027k (± 0.00%) ~ 300,019k 300,040k p=0.297 n=6
Parse Time 2.17s (± 0.48%) 2.15s (± 0.38%) ~ 2.14s 2.16s p=0.078 n=6
Bind Time 1.23s (± 1.03%) 1.24s (± 1.33%) ~ 1.22s 1.26s p=0.615 n=6
Check Time 7.21s (± 0.41%) 7.19s (± 0.68%) ~ 7.15s 7.28s p=0.334 n=6
Emit Time 4.34s (± 0.88%) 4.37s (± 0.44%) ~ 4.34s 4.39s p=0.195 n=6
Total Time 14.94s (± 0.38%) 14.94s (± 0.40%) ~ 14.85s 15.04s p=0.747 n=6
material-ui - node (v16.17.1, x64)
Memory used 476,461k (± 0.00%) 476,429k (± 0.01%) ~ 476,397k 476,462k p=0.093 n=6
Parse Time 3.22s (± 0.32%) 3.20s (± 0.28%) -0.02s (- 0.52%) 3.19s 3.21s p=0.027 n=6
Bind Time 0.95s (± 0.43%) 0.95s (± 0.43%) ~ 0.94s 0.95s p=0.218 n=6
Check Time 18.17s (± 0.46%) 18.19s (± 1.38%) ~ 18.03s 18.69s p=0.378 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 22.34s (± 0.37%) 22.34s (± 1.08%) ~ 22.17s 22.82s p=0.226 n=6
xstate - node (v16.17.1, x64)
Memory used 550,519k (± 0.02%) 550,541k (± 0.02%) ~ 550,392k 550,674k p=0.936 n=6
Parse Time 3.93s (± 0.54%) 3.94s (± 0.35%) ~ 3.92s 3.95s p=0.568 n=6
Bind Time 1.75s (± 0.93%) 1.74s (± 0.85%) ~ 1.72s 1.76s p=0.413 n=6
Check Time 3.07s (± 0.17%) 3.06s (± 0.34%) ~ 3.05s 3.08s p=0.069 n=6
Emit Time 0.09s (± 0.00%) 0.09s (± 0.00%) ~ 0.09s 0.09s p=1.000 n=6
Total Time 8.84s (± 0.37%) 8.83s (± 0.25%) ~ 8.79s 8.86s p=0.462 n=6
Angular - node (v14.15.1, x64)
Memory used 355,562k (± 0.00%) 355,578k (± 0.00%) +16k (+ 0.00%) 355,569k 355,594k p=0.005 n=6
Parse Time 3.61s (± 0.95%) 3.63s (± 0.88%) ~ 3.58s 3.67s p=0.334 n=6
Bind Time 1.22s (± 0.67%) 1.22s (± 1.12%) ~ 1.21s 1.24s p=0.445 n=6
Check Time 9.89s (± 0.56%) 9.87s (± 0.35%) ~ 9.81s 9.90s p=0.468 n=6
Emit Time 8.36s (± 0.86%) 8.41s (± 0.86%) ~ 8.30s 8.49s p=0.327 n=6
Total Time 23.08s (± 0.46%) 23.12s (± 0.35%) ~ 23.02s 23.20s p=0.809 n=6
Compiler-Unions - node (v14.15.1, x64)
Memory used 187,773k (± 0.01%) 187,777k (± 0.01%) ~ 187,752k 187,805k p=0.748 n=6
Parse Time 1.59s (± 0.73%) 1.59s (± 0.47%) ~ 1.58s 1.60s p=0.734 n=6
Bind Time 0.85s (± 0.61%) 0.84s (± 0.61%) ~ 0.84s 0.85s p=0.311 n=6
Check Time 10.50s (± 0.32%) 10.45s (± 0.44%) ~ 10.39s 10.51s p=0.065 n=6
Emit Time 3.15s (± 0.52%) 3.13s (± 0.72%) ~ 3.10s 3.16s p=0.357 n=6
Total Time 16.08s (± 0.26%) 16.01s (± 0.38%) ~ 15.94s 16.09s p=0.077 n=6
Monaco - node (v14.15.1, x64)
Memory used 340,608k (± 0.00%) 340,587k (± 0.01%) ~ 340,546k 340,620k p=0.128 n=6
Parse Time 2.82s (± 0.76%) 2.81s (± 0.22%) ~ 2.80s 2.82s p=0.558 n=6
Bind Time 1.11s (± 0.93%) 1.10s (± 0.68%) ~ 1.09s 1.11s p=0.179 n=6
Check Time 8.16s (± 0.33%) 8.16s (± 0.72%) ~ 8.09s 8.25s p=1.000 n=6
Emit Time 4.67s (± 0.98%) 4.67s (± 0.47%) ~ 4.63s 4.69s p=0.746 n=6
Total Time 16.76s (± 0.23%) 16.74s (± 0.51%) ~ 16.61s 16.87s p=0.629 n=6
TFS - node (v14.15.1, x64)
Memory used 295,081k (± 0.00%) 295,040k (± 0.00%) -41k (- 0.01%) 295,031k 295,054k p=0.005 n=6
Parse Time 2.40s (± 0.81%) 2.38s (± 0.82%) ~ 2.37s 2.42s p=0.143 n=6
Bind Time 1.06s (± 0.38%) 1.06s (± 0.49%) ~ 1.06s 1.07s p=0.595 n=6
Check Time 7.54s (± 0.27%) 7.48s (± 0.47%) -0.05s (- 0.69%) 7.44s 7.53s p=0.019 n=6
Emit Time 4.31s (± 1.15%) 4.29s (± 0.63%) ~ 4.25s 4.33s p=0.466 n=6
Total Time 15.30s (± 0.39%) 15.22s (± 0.37%) ~ 15.13s 15.29s p=0.054 n=6
material-ui - node (v14.15.1, x64)
Memory used 471,996k (± 0.00%) 471,981k (± 0.01%) ~ 471,924k 472,017k p=0.575 n=6
Parse Time 3.34s (± 0.23%) 3.34s (± 0.24%) ~ 3.33s 3.35s p=0.729 n=6
Bind Time 0.99s (± 0.82%) 1.00s (± 0.52%) ~ 0.99s 1.00s p=0.523 n=6
Check Time 19.11s (± 0.57%) 19.18s (± 0.50%) ~ 19.07s 19.34s p=0.298 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 23.45s (± 0.42%) 23.52s (± 0.42%) ~ 23.40s 23.68s p=0.422 n=6
xstate - node (v14.15.1, x64)
Memory used 539,179k (± 0.00%) 539,154k (± 0.00%) ~ 539,135k 539,175k p=0.054 n=6
Parse Time 4.22s (± 0.60%) 4.21s (± 0.35%) ~ 4.19s 4.23s p=0.332 n=6
Bind Time 1.66s (± 0.25%) 1.66s (± 0.80%) ~ 1.64s 1.68s p=0.924 n=6
Check Time 3.19s (± 0.67%) 3.20s (± 0.46%) ~ 3.18s 3.22s p=0.463 n=6
Emit Time 0.09s (± 0.00%) 0.09s (± 0.00%) ~ 0.09s 0.09s p=1.000 n=6
Total Time 9.17s (± 0.47%) 9.16s (± 0.26%) ~ 9.13s 9.19s p=0.466 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 53291 6
Baseline main 6

TSServer

Comparison Report - main..53291
Metric main 53291 Delta Best Worst p-value
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,397ms (± 0.42%) 2,400ms (± 0.39%) ~ 2,387ms 2,412ms p=0.630 n=6
Req 2 - geterr 5,537ms (± 0.67%) 5,546ms (± 0.52%) ~ 5,513ms 5,578ms p=0.936 n=6
Req 3 - references 336ms (± 0.66%) 338ms (± 1.10%) ~ 335ms 345ms p=0.326 n=6
Req 4 - navto 280ms (± 0.69%) 280ms (± 0.60%) ~ 278ms 282ms p=1.000 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 83ms (± 2.41%) 83ms (± 1.45%) ~ 81ms 84ms p=1.000 n=6
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,544ms (± 1.00%) 2,516ms (± 0.60%) -28ms (- 1.10%) 2,490ms 2,534ms p=0.045 n=6
Req 2 - geterr 4,085ms (± 0.81%) 4,077ms (± 0.54%) ~ 4,054ms 4,111ms p=0.873 n=6
Req 3 - references 351ms (± 0.46%) 352ms (± 0.71%) ~ 349ms 355ms p=1.000 n=6
Req 4 - navto 289ms (± 0.78%) 288ms (± 0.72%) ~ 285ms 290ms p=0.257 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 81ms (± 2.02%) 81ms (± 5.38%) ~ 75ms 86ms p=0.607 n=6
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 3,004ms (± 0.68%) 2,999ms (± 0.71%) ~ 2,975ms 3,025ms p=0.810 n=6
Req 2 - geterr 1,701ms (± 1.19%) 1,694ms (± 1.09%) ~ 1,677ms 1,719ms p=0.378 n=6
Req 3 - references 107ms (± 0.97%) 107ms (± 2.02%) ~ 104ms 110ms p=0.935 n=6
Req 4 - navto 357ms (± 0.39%) 356ms (± 0.68%) ~ 353ms 360ms p=0.371 n=6
Req 5 - completionInfo count 2,861 (± 0.00%) 2,861 (± 0.00%) ~ 2,861 2,861 p=1.000 n=6
Req 5 - completionInfo 386ms (± 6.31%) 374ms (± 2.08%) ~ 364ms 385ms p=0.470 n=6
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,510ms (± 0.70%) 2,510ms (± 0.47%) ~ 2,491ms 2,522ms p=0.936 n=6
Req 2 - geterr 5,917ms (± 0.28%) 5,915ms (± 0.54%) ~ 5,888ms 5,971ms p=0.470 n=6
Req 3 - references 344ms (± 0.47%) 346ms (± 0.65%) ~ 344ms 349ms p=0.162 n=6
Req 4 - navto 278ms (± 0.83%) 278ms (± 0.19%) ~ 278ms 279ms p=0.284 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 74ms (± 0.74%) 74ms (± 1.57%) ~ 73ms 76ms p=0.342 n=6
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,678ms (± 0.49%) 2,685ms (± 0.59%) ~ 2,661ms 2,700ms p=0.378 n=6
Req 2 - geterr 4,410ms (± 0.52%) 4,420ms (± 0.37%) ~ 4,405ms 4,440ms p=0.688 n=6
Req 3 - references 364ms (± 0.34%) 364ms (± 0.82%) ~ 359ms 368ms p=0.397 n=6
Req 4 - navto 287ms (± 0.57%) 288ms (± 0.26%) ~ 287ms 289ms p=0.131 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 77ms (± 1.58%) 76ms (± 0.00%) ~ 76ms 76ms p=0.176 n=6
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 3,147ms (± 0.19%) 3,144ms (± 0.22%) ~ 3,136ms 3,155ms p=0.520 n=6
Req 2 - geterr 1,842ms (± 0.97%) 1,846ms (± 1.14%) ~ 1,825ms 1,880ms p=0.748 n=6
Req 3 - references 112ms (± 0.73%) 113ms (± 1.18%) ~ 111ms 115ms p=0.546 n=6
Req 4 - navto 342ms (± 0.74%) 341ms (± 0.50%) ~ 338ms 343ms p=0.566 n=6
Req 5 - completionInfo count 2,861 (± 0.00%) 2,861 (± 0.00%) ~ 2,861 2,861 p=1.000 n=6
Req 5 - completionInfo 401ms (± 5.25%) 395ms (± 1.11%) ~ 390ms 400ms p=1.000 n=6
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,605ms (± 0.27%) 2,603ms (± 0.51%) ~ 2,584ms 2,618ms p=0.810 n=6
Req 2 - geterr 6,325ms (± 0.57%) 6,356ms (± 0.82%) ~ 6,292ms 6,416ms p=0.298 n=6
Req 3 - references 363ms (± 0.29%) 366ms (± 1.10%) ~ 358ms 370ms p=0.064 n=6
Req 4 - navto 281ms (± 0.88%) 281ms (± 1.13%) ~ 278ms 287ms p=1.000 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 97ms (± 4.62%) 99ms (± 5.58%) ~ 88ms 102ms p=0.677 n=6
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,815ms (± 0.57%) 2,811ms (± 0.34%) ~ 2,798ms 2,826ms p=0.630 n=6
Req 2 - geterr 4,790ms (± 0.44%) 4,775ms (± 0.39%) ~ 4,762ms 4,811ms p=0.261 n=6
Req 3 - references 371ms (± 0.53%) 371ms (± 0.48%) ~ 369ms 373ms p=0.801 n=6
Req 4 - navto 294ms (± 1.30%) 290ms (± 0.94%) ~ 288ms 295ms p=0.143 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 75ms (± 0.73%) 74ms (± 0.85%) ~ 73ms 75ms p=0.201 n=6
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,446ms (± 0.36%) 3,444ms (± 0.59%) ~ 3,423ms 3,482ms p=0.470 n=6
Req 2 - geterr 1,884ms (± 0.99%) 1,882ms (± 0.92%) ~ 1,849ms 1,897ms p=0.521 n=6
Req 3 - references 124ms (± 0.94%) 124ms (± 0.83%) ~ 122ms 125ms p=1.000 n=6
Req 4 - navto 372ms (± 0.67%) 370ms (± 0.36%) ~ 369ms 372ms p=0.217 n=6
Req 5 - completionInfo count 2,861 (± 0.00%) 2,861 (± 0.00%) ~ 2,861 2,861 p=1.000 n=6
Req 5 - completionInfo 409ms (± 0.94%) 408ms (± 0.55%) ~ 405ms 411ms p=0.513 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 53291 6
Baseline main 6

Startup

Comparison Report - main..53291
Metric main 53291 Delta Best Worst p-value
tsc-startup - node (v16.17.1, x64)
Execution time 141.31ms (± 0.19%) 141.75ms (± 0.20%) +0.44ms (+ 0.31%) 141.05ms 146.77ms p=0.000 n=600
tsserver-startup - node (v16.17.1, x64)
Execution time 226.36ms (± 0.20%) 227.15ms (± 0.14%) +0.79ms (+ 0.35%) 226.22ms 231.76ms p=0.000 n=600
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time 228.23ms (± 0.15%) 228.95ms (± 0.16%) +0.72ms (+ 0.31%) 227.98ms 233.34ms p=0.000 n=600
typescript-startup - node (v16.17.1, x64)
Execution time 209.08ms (± 0.20%) 209.56ms (± 0.15%) +0.48ms (+ 0.23%) 208.74ms 213.81ms p=0.000 n=600
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current 53291 6
Baseline main 6

Developer Information:

Download Benchmark

sandersn
sandersn approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go in before the beta, right?

@jakebailey
Copy link
Member Author

Yes, though I'd like to bikeshed es2019/es2020.

@jakebailey
Copy link
Member Author

ugh, i just realized that the perf runner is using 14.15.1 which is older. Maybe 14.13 is the right thing

@jakebailey
Copy link
Member Author

@typescript-bot perf test this faster

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 14, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the abridged perf test suite on this PR at 49f70c2. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..53291

Metric main 53291 Delta Best Worst p-value
Angular - node (v16.17.1, x64)
Memory used 364,597k (± 0.01%) 364,544k (± 0.01%) -53k (- 0.01%) 364,480k 364,569k p=0.020 n=6
Parse Time 3.54s (± 0.52%) 3.54s (± 0.15%) ~ 3.53s 3.54s p=0.667 n=6
Bind Time 1.18s (± 0.87%) 1.17s (± 1.03%) ~ 1.16s 1.19s p=0.210 n=6
Check Time 9.52s (± 0.19%) 9.47s (± 0.43%) -0.05s (- 0.53%) 9.41s 9.51s p=0.043 n=6
Emit Time 7.99s (± 0.45%) 7.95s (± 0.30%) ~ 7.93s 7.99s p=0.104 n=6
Total Time 22.23s (± 0.20%) 22.14s (± 0.26%) -0.10s (- 0.45%) 22.03s 22.20s p=0.013 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used 192,643k (± 0.01%) 192,541k (± 0.03%) -102k (- 0.05%) 192,480k 192,606k p=0.005 n=6
Parse Time 1.59s (± 0.47%) 1.57s (± 1.78%) ~ 1.54s 1.60s p=0.209 n=6
Bind Time 0.83s (± 0.66%) 0.82s (± 0.50%) ~ 0.82s 0.83s p=0.282 n=6
Check Time 10.22s (± 0.91%) 10.21s (± 0.49%) ~ 10.16s 10.30s p=0.810 n=6
Emit Time 2.99s (± 0.87%) 2.98s (± 0.55%) ~ 2.97s 3.00s p=0.869 n=6
Total Time 15.63s (± 0.61%) 15.59s (± 0.55%) ~ 15.49s 15.73s p=0.520 n=6
Monaco - node (v16.17.1, x64)
Memory used 345,780k (± 0.01%) 345,759k (± 0.00%) ~ 345,738k 345,779k p=0.093 n=6
Parse Time 2.73s (± 0.55%) 2.72s (± 0.20%) ~ 2.71s 2.72s p=0.099 n=6
Bind Time 1.09s (± 0.37%) 1.08s (± 0.38%) -0.01s (- 0.61%) 1.08s 1.09s p=0.034 n=6
Check Time 7.83s (± 0.30%) 7.81s (± 0.82%) ~ 7.76s 7.93s p=0.147 n=6
Emit Time 4.49s (± 0.97%) 4.45s (± 0.57%) ~ 4.42s 4.49s p=0.169 n=6
Total Time 16.13s (± 0.36%) 16.06s (± 0.52%) ~ 15.99s 16.22s p=0.107 n=6
TFS - node (v16.17.1, x64)
Memory used 300,050k (± 0.01%) 300,041k (± 0.01%) ~ 300,020k 300,083k p=0.688 n=6
Parse Time 2.16s (± 0.54%) 2.15s (± 0.46%) ~ 2.14s 2.16s p=0.157 n=6
Bind Time 1.24s (± 1.19%) 1.23s (± 0.85%) ~ 1.22s 1.25s p=0.619 n=6
Check Time 7.21s (± 0.27%) 7.20s (± 0.44%) ~ 7.16s 7.25s p=0.225 n=6
Emit Time 4.34s (± 0.27%) 4.35s (± 0.43%) ~ 4.32s 4.37s p=0.461 n=6
Total Time 14.95s (± 0.19%) 14.93s (± 0.23%) ~ 14.89s 14.99s p=0.147 n=6
material-ui - node (v16.17.1, x64)
Memory used 481,093k (± 0.00%) 481,053k (± 0.01%) ~ 481,006k 481,090k p=0.054 n=6
Parse Time 3.25s (± 0.16%) 3.24s (± 0.54%) ~ 3.22s 3.26s p=0.934 n=6
Bind Time 0.95s (± 0.94%) 0.94s (± 0.58%) ~ 0.94s 0.95s p=0.341 n=6
Check Time 17.76s (± 0.31%) 17.75s (± 0.27%) ~ 17.69s 17.84s p=0.871 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 21.96s (± 0.25%) 21.95s (± 0.18%) ~ 21.90s 22.02s p=0.744 n=6
xstate - node (v16.17.1, x64)
Memory used 559,379k (± 0.02%) 559,340k (± 0.02%) ~ 559,217k 559,439k p=0.575 n=6
Parse Time 3.98s (± 0.49%) 3.98s (± 0.26%) ~ 3.97s 4.00s p=0.808 n=6
Bind Time 1.75s (± 0.63%) 1.75s (± 0.59%) ~ 1.73s 1.76s p=0.676 n=6
Check Time 3.01s (± 0.27%) 3.02s (± 0.42%) ~ 3.00s 3.03s p=0.284 n=6
Emit Time 0.09s (± 0.00%) 0.09s (± 0.00%) ~ 0.09s 0.09s p=1.000 n=6
Total Time 8.84s (± 0.35%) 8.84s (± 0.23%) ~ 8.82s 8.87s p=0.935 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • Angular - node (v16.17.1, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Monaco - node (v16.17.1, x64)
  • TFS - node (v16.17.1, x64)
  • material-ui - node (v16.17.1, x64)
  • xstate - node (v16.17.1, x64)
Benchmark Name Iterations
Current 53291 6
Baseline main 6

Developer Information:

Download Benchmark

@jakebailey
Copy link
Member Author

I have bumped the perf runner to 14.21.3 for its copy of Node 14. I may bump the others later but I don't want to break continuity too badly.

I'm going to try and do this PR for 5.1; if people complain, we can easily roll it back.

@jakebailey jakebailey added the Breaking Change Would introduce errors in existing code label Apr 15, 2023
@jakebailey jakebailey merged commit 04f813d into microsoft:main Apr 15, 2023
@jakebailey jakebailey deleted the node-14 branch April 15, 2023 02:36
@trentm trentm mentioned this pull request Jun 5, 2023
Merged
@daiplusplus daiplusplus mentioned this pull request Jun 17, 2023
Closed
@daiplusplus
Copy link

FWIW, AFAICT this PR broke compatibility with Visual Studio 2019, as the Microsoft.TypeScript.MSBuild 5.1+ NuGet package's MSBuild .targets and .props files always use VS's node.exe which in VS2019 is (always?) version 12 - so building a solution from within VS fails.

I've documented that in this issue: #54686

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn sandersn approved these changes

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh

Assignees

@jakebailey jakebailey

Labels
Author: Team Breaking Change Would introduce errors in existing code For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jakebailey @sandersn @typescript-bot @daiplusplus @DanielRosenwasser