Skip to content

fix(57141): override keyword doesn't check symbol-key class members #57146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 12, 2024

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #57141

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Jan 23, 2024
Copy link
Member

@iisaduan iisaduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nodeModules.... baselines should be reverted since #57220 was merged after this PR was last updated. Pulling/merging main, and then updating baselines should revert them!

Otherwise, the PR looks good!

@a-tarasyuk a-tarasyuk requested a review from iisaduan March 12, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

override keyword doesn't check symbol-key class members
4 participants