Add new option "noUncheckedSideEffectImports" #58941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
|
@typescript-bot test it |
|
Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page. Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up. |
|
Hey @jakebailey, the results of running the DT tests are ready. There were interesting changes: Branch only errors:Package: array.prototype.find Package: howler Package: page-flip Package: redux-shortcuts Package: array.prototype.every Package: behavior3 Package: string.prototype.trim Package: strophe Package: bootstrap-toggle Package: mapbox__aws-sdk-jest Package: siren-parser Package: utif Package: wonder.js Package: hapi/v17 Package: baidumap-web-sdk Package: object.groupby Package: source-map-support Package: hapi Package: aws-synthetics-puppeteer Package: terminal-kit Package: babel-types Package: iitc Package: ember-feature-flags/v3 Package: npm-which Package: react-smartbanner Package: ember-feature-flags Package: smartwizard/v4 Package: browser-report Package: object.assign Package: vue-moment Package: openfin/v50 Package: smartwizard Package: bcswipe Package: pannellum Package: function.prototype.name Package: setimmediate Package: splitting Package: tablesorter Package: bootstrap4-toggle Package: format-unicorn Package: jquery-deserialize Package: vue3-carousel-3d Package: ecma-proposal-math-extensions Package: gun Package: reflect.ownkeys Package: error-cause Package: array.prototype.flatmap Package: bmapgl-browser Package: react-katex Package: array.prototype.flat Package: cloudinary-uploadwidget-browser Errors that changed between main and the branch:Package: node/v16 Branch error: Package: node/v18 Branch error: Package: node Branch error: |
|
@jakebailey Here are the results of running the user tests with tsc comparing Something interesting changed - please have a look. Details
|
|
@jakebailey Here they are:
tscComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
@jakebailey Here are the results of running the top 400 repos with tsc comparing Something interesting changed - please have a look. Details
|
|
@jakebailey Here are some more interesting changes from running the top 400 repos suite Details
|
|
@jakebailey Here are some more interesting changes from running the top 400 repos suite Details
|
|
@jakebailey Here are some more interesting changes from running the top 400 repos suite Details
|
|
@jakebailey Here are some more interesting changes from running the top 400 repos suite Details
|
|
@jakebailey Here are some more interesting changes from running the top 400 repos suite Details
|
|
@jakebailey Here are some more interesting changes from running the top 400 repos suite Details
|
|
@jakebailey Here are some more interesting changes from running the top 400 repos suite Details
|
|
@jakebailey Here are some more interesting changes from running the top 400 repos suite Details
|
|
The user/top tests are pretty much as expected; css/sass etc. But what's more interesting are the DT results. There's a load of stuff there that is probably just plain broken on DT. |
|
100% this should not be called "bare", as I believe that actually means imports like "foo" versus "./blah" or something. Oops. |
This reverts commit b7eda58.
jakebailey
changed the title
This was referenced Jun 20, 2024
|
I am opening this up for review; we still need to bikeshed the name. Honestly, I'm still still thinking |
|
Good point, I should add that test. |
jakebailey
changed the title
|
Flag name has been updated to |
sheetalkamat
requested changes
Jul 19, 2024
andrewbranch
approved these changes
Jul 19, 2024
RyanCavanaugh
approved these changes
Jul 19, 2024
|
Thank you! 👍 |
|
Nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
noUncheckedSideEffectImportsis enabled, imports like:Are now resolved and can produce resolution errors.
Closes #50394
See also #58725 (comment)
TODO:
checkSideEffectImportsor somethingFuture: