Properly account for type parameters introduced by contextual types #59516

ahejlsberg · 2024-08-02T17:36:30Z

ahejlsberg · 2024-08-02T17:36:44Z

typescript-bot · 2024-08-02T17:36:48Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	👀 Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-08-02T17:58:47Z

Hey @ahejlsberg, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-08-02T18:03:34Z

@ahejlsberg Here are the results of running the user tests with tsc comparing main and refs/pull/59516/merge:

Everything looks good!

typescript-bot · 2024-08-02T18:20:26Z

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,542k (± 0.95%)}	_{193,007k (± 0.73%)}	_~	_192,322k	_195,885k	_{p=1.000 n=6}
_{Parse Time}	_{1.30s (± 1.34%)}	_{1.30s (± 1.41%)}	_~	_1.28s	_1.33s	_{p=0.803 n=6}
_{Bind Time}	_{0.71s (± 0.58%)}	_0.71s	_~	_~	_~	_{p=0.405 n=6}
_{Check Time}	_{9.57s (± 0.42%)}	_{9.55s (± 0.34%)}	_~	_9.50s	_9.59s	_{p=0.374 n=6}
_{Emit Time}	_{2.73s (± 1.55%)}	_{2.75s (± 0.71%)}	_~	_2.72s	_2.77s	_{p=0.375 n=6}
_{Total Time}	_{14.31s (± 0.21%)}	_{14.30s (± 0.23%)}	_~	_14.27s	_14.35s	_{p=0.629 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_945,537	_945,537	_~	_~	_~	_{p=1.000 n=6}
_Types	_409,512	_409,512	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,258k (± 0.01%)}	_{1,222,275k (± 0.00%)}	_~	_1,222,229k	_1,222,314k	_{p=0.936 n=6}
_{Parse Time}	_{6.60s (± 0.87%)}	_{6.61s (± 0.76%)}	_~	_6.58s	_6.70s	_{p=0.466 n=6}
_{Bind Time}	_{1.86s (± 0.56%)}	_{1.86s (± 0.28%)}	_~	_1.86s	_1.87s	_{p=0.794 n=6}
_{Check Time}	_{31.22s (± 0.27%)}	_{31.17s (± 0.34%)}	_~	_31.06s	_31.31s	_{p=0.377 n=6}
_{Emit Time}	_{15.12s (± 1.16%)}	_{14.96s (± 0.65%)}	_~	_14.86s	_15.12s	_{p=0.108 n=6}
_{Total Time}	_{54.80s (± 0.46%)}	_{54.61s (± 0.42%)}	_~	_54.40s	_54.96s	_{p=0.229 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,483,478	_2,483,478	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,012,731	_1,012,731	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,475,367k (± 0.00%)}	_{2,475,412k (± 0.00%)}	_~	_2,475,404k	_2,475,421k	_{p=0.066 n=6}
_{Parse Time}	_{8.79s (± 0.56%)}	_{8.79s (± 0.54%)}	_~	_8.74s	_8.85s	_{p=1.000 n=6}
_{Bind Time}	_{2.18s (± 0.45%)}	_{2.17s (± 0.38%)}	_~	_2.16s	_2.18s	_{p=0.282 n=6}
_{Check Time}	_{75.42s (± 0.46%)}	_{75.98s (± 1.43%)}	_~	_74.88s	_78.05s	_{p=0.298 n=6}
_{Emit Time}	_{0.28s (± 2.70%)}	_{0.28s (± 3.53%)}	_~	_0.27s	_0.29s	_{p=1.000 n=6}
_{Total Time}	_{86.67s (± 0.45%)}	_{87.23s (± 1.22%)}	_~	_86.09s	_89.22s	_{p=0.298 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,227,919	_1,227,921	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_265,192	_265,194	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,406,351k (± 6.00%)}	_{2,346,843k (± 0.02%)}	_~	_2,346,306k	_2,347,541k	_{p=0.173 n=6}
_{Parse Time}	_{4.97s (± 0.80%)}	_{4.92s (± 1.03%)}	_{-0.05s (- 1.11%)}	_4.82s	_4.95s	_{p=0.044 n=6}
_{Bind Time}	_{1.89s (± 0.43%)}	_{1.90s (± 0.40%)}	_~	_1.89s	_1.91s	_{p=0.120 n=6}
_{Check Time}	_{34.56s (± 0.38%)}	_{34.61s (± 0.26%)}	_~	_34.48s	_34.72s	_{p=0.470 n=6}
_{Emit Time}	_{3.28s (± 1.38%)}	_{3.30s (± 0.89%)}	_~	_3.26s	_3.33s	_{p=0.628 n=6}
_{Total Time}	_{44.73s (± 0.26%)}	_{44.75s (± 0.20%)}	_~	_44.64s	_44.90s	_{p=0.936 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,227,919	_1,227,921	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_265,192	_265,194	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,420,903k (± 0.02%)}	_{2,421,695k (± 0.03%)}	_~	_2,420,231k	_2,422,438k	_{p=0.093 n=6}
_{Parse Time}	_{7.71s (± 0.62%)}	_{7.71s (± 0.66%)}	_~	_7.61s	_7.76s	_{p=0.936 n=6}
_{Bind Time}	_{2.50s (± 0.53%)}	_{2.51s (± 1.22%)}	_~	_2.47s	_2.56s	_{p=0.628 n=6}
_{Check Time}	_{50.88s (± 0.57%)}	_{50.97s (± 0.56%)}	_~	_50.75s	_51.51s	_{p=0.689 n=6}
_{Emit Time}	_{5.09s (± 3.81%)}	_{5.05s (± 3.73%)}	_~	_4.91s	_5.42s	_{p=0.810 n=6}
_{Total Time}	_{66.21s (± 0.49%)}	_{66.26s (± 0.53%)}	_~	_65.86s	_66.84s	_{p=1.000 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_256,031	_256,033	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,976	_104,978	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{428,033k (± 0.05%)}	_{428,094k (± 0.06%)}	_~	_427,835k	_428,398k	_{p=0.936 n=6}
_{Parse Time}	_{3.36s (± 0.83%)}	_{3.35s (± 0.33%)}	_~	_3.33s	_3.36s	_{p=0.681 n=6}
_{Bind Time}	_{1.31s (± 1.15%)}	_{1.31s (± 1.15%)}	_~	_1.29s	_1.32s	_{p=0.437 n=6}
_{Check Time}	_{17.99s (± 0.23%)}	_{18.05s (± 0.25%)}	_~	_17.98s	_18.10s	_{p=0.076 n=6}
_{Emit Time}	_{1.64s (± 1.66%)}	_{1.64s (± 1.37%)}	_~	_1.62s	_1.68s	_{p=1.000 n=6}
_{Total Time}	_{24.31s (± 0.25%)}	_{24.35s (± 0.28%)}	_~	_24.23s	_24.43s	_{p=0.375 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,931	_224,931	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,146	_94,146	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,236k (± 0.05%)}	_{370,132k (± 0.04%)}	_~	_369,942k	_370,333k	_{p=0.378 n=6}
_{Parse Time}	_{2.77s (± 0.40%)}	_{2.75s (± 1.06%)}	_~	_2.71s	_2.78s	_{p=0.452 n=6}
_{Bind Time}	_{1.58s (± 1.33%)}	_{1.58s (± 0.67%)}	_~	_1.56s	_1.59s	_{p=1.000 n=6}
_{Check Time}	_{15.62s (± 0.33%)}	_{15.69s (± 0.46%)}	_~	_15.57s	_15.76s	_{p=0.148 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.97s (± 0.16%)}	_{20.01s (± 0.29%)}	_~	_19.91s	_20.09s	_{p=0.090 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,990,805	_2,990,805	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,029,115	_1,029,118	_{+3 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,116,010k (± 0.00%)}	_{3,116,056k (± 0.00%)}	_~	_3,115,920k	_3,116,205k	_{p=0.471 n=6}
_{Parse Time}	_{17.01s (± 0.58%)}	_{16.98s (± 0.42%)}	_~	_16.87s	_17.05s	_{p=0.748 n=6}
_{Bind Time}	_{5.30s (± 2.53%)}	_{5.31s (± 2.58%)}	_~	_5.19s	_5.49s	_{p=0.683 n=6}
_{Check Time}	_{96.46s (± 0.49%)}	_{96.25s (± 0.31%)}	_~	_95.82s	_96.70s	_{p=0.336 n=6}
_{Emit Time}	_{25.07s (± 0.36%)}	_{25.04s (± 0.55%)}	_~	_24.84s	_25.23s	_{p=0.810 n=6}
_{Total Time}	_{143.83s (± 0.34%)}	_{143.59s (± 0.31%)}	_~	_143.08s	_144.22s	_{p=0.471 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_268,265	_268,265	_~	_~	_~	_{p=1.000 n=6}
_Types	_109,187	_109,187	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{413,065k (± 0.01%)}	_{413,116k (± 0.01%)}	_{+50k (+ 0.01%)}	_413,077k	_413,185k	_{p=0.045 n=6}
_{Parse Time}	_{3.81s (± 0.54%)}	_{3.81s (± 0.43%)}	_~	_3.79s	_3.83s	_{p=0.935 n=6}
_{Bind Time}	_{1.71s (± 0.95%)}	_{1.71s (± 0.68%)}	_~	_1.69s	_1.72s	_{p=0.445 n=6}
_{Check Time}	_{16.79s (± 0.34%)}	_{16.79s (± 0.28%)}	_~	_16.73s	_16.86s	_{p=1.000 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.31s (± 0.38%)}	_{22.31s (± 0.26%)}	_~	_22.24s	_22.39s	_{p=0.936 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_538,543	_538,543	_~	_~	_~	_{p=1.000 n=6}
_Types	_176,469	_176,469	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{481,329k (± 0.02%)}	_{481,372k (± 0.01%)}	_~	_481,301k	_481,447k	_{p=0.521 n=6}
_{Parse Time}	_{3.42s (± 1.24%)}	_{3.43s (± 0.75%)}	_~	_3.39s	_3.45s	_{p=0.808 n=6}
_{Bind Time}	_{1.26s (± 0.93%)}	_{1.25s (± 0.67%)}	_~	_1.24s	_1.26s	_{p=0.547 n=6}
_{Check Time}	_{17.99s (± 0.36%)}	_{18.04s (± 0.16%)}	_~	_17.99s	_18.07s	_{p=0.229 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.67s (± 0.40%)}	_{22.72s (± 0.24%)}	_~	_22.62s	_22.76s	_{p=0.148 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-08-02T19:17:53Z

@ahejlsberg Here are the results of running the top 400 repos with tsc comparing main and refs/pull/59516/merge:

Something interesting changed - please have a look.

Details

honojs/hono

5 of 6 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2769: No overload matches this call.
- src/types.test.ts#L2260

ahejlsberg · 2024-08-02T23:44:36Z

Performance is unaffected. One new error in honojs/hono, a top 400 repo. The new error is correct, but wasn't previously detected because instantiations of the type of { data } object literal weren't correctly resolved for the contextually injected TData type parameter. So, I think this is good to merge.

m-shaka · 2024-08-03T03:48:38Z

Yeah, it's me who added this test of hono.js and I expected the failure. You can go forward

jakebailey · 2024-08-03T04:12:37Z

src/compiler/checker.ts

+                    if ((kind === SyntaxKind.FunctionExpression || kind === SyntaxKind.ArrowFunction || isObjectLiteralMethod(node)) && isContextSensitive(node as Expression | MethodDeclaration)) {
+                        const signature = firstOrUndefined(getSignaturesOfType(getTypeOfSymbol(getSymbolOfDeclaration(node as FunctionLikeDeclaration)), SignatureKind.Call));
+                        if (signature && signature.typeParameters) {
+                            return [...(outerTypeParameters || emptyArray), ...signature.typeParameters];


Should this be concatenate like the other cases? (Should also get rid of the empty array since I think it accepts undefined)

We are required to return a mutable array, and concatenate only returns a mutable array when both arguments are mutable arrays. In this case, signature.typeParameters is read-only.

Can't get rid of the empty array, spreading undefined causes an exception.

I meant more that concatenate can accept undefined so you don't have to || things, but, yeah, it doesn't return a copy.

Though it's sort of confusing given all of the surrounding code uses append / concatenate

ahejlsberg added 2 commits August 2, 2024 10:34

Account for contextual type parameters in getOuterTypeParameters

5b502e6

Add tests

6c6eb33

typescript-bot assigned ahejlsberg Aug 2, 2024

typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Aug 2, 2024

ahejlsberg requested review from DanielRosenwasser and RyanCavanaugh August 2, 2024 23:44

jakebailey reviewed Aug 3, 2024

View reviewed changes

Andarist mentioned this pull request Aug 3, 2024

Fixed conditional type deferral when using deferred type references with type parameters from contextual signature #59481

Closed

jakebailey approved these changes Aug 6, 2024

View reviewed changes

ahejlsberg merged commit 278cb94 into main Aug 8, 2024
32 checks passed

ahejlsberg deleted the fix59450 branch August 8, 2024 20:38

m-shaka mentioned this pull request Aug 22, 2024

test(types): broken test in future versions of typescript honojs/hono#3310

Merged

4 tasks

sandersn removed this from PR Backlog Apr 22, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Properly account for type parameters introduced by contextual types #59516

Properly account for type parameters introduced by contextual types #59516

ahejlsberg commented Aug 2, 2024

ahejlsberg commented Aug 2, 2024

typescript-bot commented Aug 2, 2024 •

edited

Loading

typescript-bot commented Aug 2, 2024

typescript-bot commented Aug 2, 2024

typescript-bot commented Aug 2, 2024

tsc

typescript-bot commented Aug 2, 2024

honojs/hono

tsconfig.json

ahejlsberg commented Aug 2, 2024

m-shaka commented Aug 3, 2024

jakebailey Aug 3, 2024 •

edited

Loading

ahejlsberg Aug 3, 2024

jakebailey Aug 6, 2024

Properly account for type parameters introduced by contextual types #59516

Properly account for type parameters introduced by contextual types #59516

Conversation

ahejlsberg commented Aug 2, 2024

ahejlsberg commented Aug 2, 2024

typescript-bot commented Aug 2, 2024 • edited Loading

typescript-bot commented Aug 2, 2024

typescript-bot commented Aug 2, 2024

typescript-bot commented Aug 2, 2024

tsc

typescript-bot commented Aug 2, 2024

honojs/hono

tsconfig.json

ahejlsberg commented Aug 2, 2024

m-shaka commented Aug 3, 2024

jakebailey Aug 3, 2024 • edited Loading

Choose a reason for hiding this comment

ahejlsberg Aug 3, 2024

Choose a reason for hiding this comment

jakebailey Aug 6, 2024

Choose a reason for hiding this comment

typescript-bot commented Aug 2, 2024 •

edited

Loading

jakebailey Aug 3, 2024 •

edited

Loading