-
Notifications
You must be signed in to change notification settings - Fork 13.1k
Do not indent semicolons on new lines #59736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Do not indent semicolons on new lines #59736
Conversation
|
@typescript-bot pack this |
|
Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your and then running There is also a playground for this build and an npm module you can use via |
|
I'm surprised there's no test for this, but there's a change where the following type X =
| 1
| 2
| 3
;is now formatted into: type X =
| 1
| 2
| 3
;We also used to support going the opposite way, where the latter was formatted into the former. I don't think that that's desirable. Not sure if others have opinions here. |
|
Yeah, that would probably be a regression. Should definitely have a test for it... |
|
Hmm. That's going to require scanning forward to see if the Since that adds probably too much complexity, maybe it would be best to only do what this commit does if the |
…remove", add new comprehensive test covering many scenarios
581c0c8 to
64edd9b
Compare
Fixes #48571