Skip to content

Make an error message related to the PropertyDecorator kinder #61637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make an error message related to the PropertyDecorator kinder #61637

wants to merge 2 commits into from

Conversation

o-m12a
Copy link

@o-m12a o-m12a commented May 1, 2025

Fixes #4534

  • There is an associated issue in the Backlog milestone (required)
  • Code is up-to-date with the main branch
  • You've successfully run hereby runtests locally
  • There are new or updated unit tests validating the change

What I did

  • make some interfaces give and return DiagnosticAndArguments instead of DiagnosticMessage
  • improve the error message as mentioned at #4534 (comment)

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label May 1, 2025
@o-m12a
Copy link
Author

o-m12a commented May 1, 2025

@o-m12a please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree 👍

@o-m12a
Copy link
Author

o-m12a commented May 1, 2025

@microsoft-github-policy-service agree

@o-m12a o-m12a marked this pull request as ready for review May 1, 2025 04:42
@o-m12a o-m12a mentioned this pull request May 1, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve error message for decorator type mismatches
2 participants
@o-m12a @typescript-bot