Excess property check numeric indexers #8822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, having a numeric indexer on a target type meant that excess object property checking would allow any property. Now only numeric properties are allowed.
A lot of tests used non-numeric property names for object literals that are contextually typed only by a numeric indexer.
| tests/cases/conformance/types/objectTypeLiteral/indexSignatures/numericIndexerConstrainsPropertyDeclarations.ts(78,5): error TS2322: Type '{ 1.0: string; 2.0: number; a: string; b: number; c: () => void; "d": string; "e": number; "3.0": string; "4.0": number; f: any; X: string; foo(): string; }' is not assignable to type '{ [x: number]: string; }'. | ||
| Property '2.0' is incompatible with index signature. | ||
| Type 'number' is not assignable to type 'string'. | ||
| tests/cases/conformance/types/objectTypeLiteral/indexSignatures/numericIndexerConstrainsPropertyDeclarations.ts(79,5): error TS2322: Type '{ 1.0: string; 2.0: number; a: string; b: number; c: () => void; "d": string; "e": number; "3.0": string; "4.0": number; f: any; X: string; foo(): string; }' is not assignable to type '{ [x: number]: string; }'. |
There was a problem hiding this comment.
the previous error was definitely more helpful.
There was a problem hiding this comment.
actually this looks just wrong.
There was a problem hiding this comment.
really? I think it's correct to point out that 'a' is not expected in a number-indexed type. And the error locality is better than the assignability error.
I guess the ideal would be to issue both errors?
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8768.
A lot of tests used non-numeric property names for object literals that are contextually typed only by a numeric indexer. I changed the tests to use numeric names after reading them. I don't think any of them depended on the non-numeric names.