Skip to content

Conversation

@OneBlue
Copy link
Collaborator

@OneBlue OneBlue commented May 28, 2025

Summary of the Pull Request

This pull request solves a regression introduced in 2.5.7 causing docker's init.d script to fail to start

PR Checklist

  • Closes: Link to issue WSL prerelease breaks docker startup init with ulimit -Hn 524288 #12985 12985
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated if needed and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated if needed
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

We have increased the soft file descriptor limit to 1,048,576, and given that the hard file descriptor limit cannot be lower than the soft one (which is what ulimit -Hn 524288 is trying to do), that command fails.

Validation Steps Performed

Validated that docker successfully starts

@OneBlue OneBlue closed this May 29, 2025
@OneBlue OneBlue reopened this May 29, 2025
@OneBlue
Copy link
Collaborator Author

OneBlue commented May 29, 2025

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@OneBlue OneBlue merged commit 827a987 into master May 30, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants