Skip to content

Users/tihuang/certsupport #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2017
Merged

Conversation

TingluoHuang
Copy link
Contributor

No description provided.

@msftclas
Copy link

@TingluoHuang,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


// try get proxy setting from environment variable set by VSTS-Task-Lib if there is no proxy setting in the options
if (!this.options.proxy || !this.options.proxy.proxyUrl) {
if (global['_vsts_task_lib_proxy']) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

global vs process.env? I've always used the latter.

@TingluoHuang TingluoHuang force-pushed the users/tihuang/certsupport branch from f39f1f3 to 1d100f9 Compare August 23, 2017 15:31
@bryanmacfarlane bryanmacfarlane merged commit d467665 into master Aug 29, 2017
@TingluoHuang TingluoHuang deleted the users/tihuang/certsupport branch August 29, 2017 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants