Skip to content

Upgrade mysql to 8.0.42 for fixing 25 CVEs #13955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: fasttrack/2.0
Choose a base branch
from
Open

Upgrade mysql to 8.0.42 for fixing 25 CVEs #13955

wants to merge 1 commit into from
+15 −466

Conversation

Kanishk-Bansal
Copy link
Contributor

@Kanishk-Bansal Kanishk-Bansal commented Jun 4, 2025 •
edited
Loading

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge
Summary

What does the PR accomplish, why was it needed?

Change Log
Does this affect the toolchain?

YES

Associated issues
  • #xxxx
Links to CVEs
Test Methodology

Upgrade mysql to 8.0.42
d50ab7b 
Signed-off-by: Kanishk Bansal <[email protected]>
@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging fasttrack/2.0 PRs Destined for Azure Linux 2.0 labels Jun 4, 2025
@Kanishk-Bansal Kanishk-Bansal marked this pull request as ready for review June 4, 2025 10:41
@Kanishk-Bansal Kanishk-Bansal requested a review from a team as a code owner June 4, 2025 10:41
@PawelWMS PawelWMS added the CVEFixReadyForMaintainerReview When a CVE fix has been reviewed by release manager and is ready for stable maintainer review label Jun 5, 2025
jslobodzian
jslobodzian requested changes Jun 9, 2025
View reviewed changes
Copy link
Collaborator

@jslobodzian jslobodzian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pTest for mysql is failing on 2.0. This is normal for 2.0, but I believe we had it passing on 3.0, so we should fix this on 2.0 as well.

@sameluch
Copy link
Contributor

sameluch commented Jun 9, 2025

The pTest for mysql is failing on 2.0. This is normal for 2.0, but I believe we had it passing on 3.0, so we should fix this on 2.0 as well.

@Kanishk-Bansal
The actual underlying test failing is merge_large_tests. This is what is failing for both AMD64 and ARM64 on 2.0, and is passing on 3.0 AMD64. Maybe there is a dependency difference.

For 3.0 the test is failing due to the same merge_large_tests as well as routertest_integration_routing_sharing_constrained_pools. While this doesn't technically matter for this PR, if it can be resolve for 2.0 in both arches, the fix can also potentially be used to partially clear up the failure in aarch64 3.0 as well. Since we have the same mysql version between both 2.0 and 3.0.

@jslobodzian
Copy link
Collaborator

The pTest for mysql is failing on 2.0. This is normal for 2.0, but I believe we had it passing on 3.0, so we should fix this on 2.0 as well.

@Kanishk-Bansal The actual underlying test failing is merge_large_tests. This is what is failing for both AMD64 and ARM64 on 2.0, and is passing on 3.0 AMD64. Maybe there is a dependency difference.

For 3.0 the test is failing due to the same merge_large_tests as well as routertest_integration_routing_sharing_constrained_pools. While this doesn't technically matter for this PR, if it can be resolve for 2.0 in both arches, the fix can also potentially be used to partially clear up the failure in aarch64 3.0 as well. Since we have the same mysql version between both 2.0 and 3.0.

@Kanishk-Bansal feel free to patch this test out given that 2.0 is nearing end of life and this has historically failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jslobodzian jslobodzian jslobodzian requested changes

@mfrw mfrw mfrw approved these changes

@PawelWMS PawelWMS PawelWMS approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
CVEFixReadyForMaintainerReview When a CVE fix has been reviewed by release manager and is ready for stable maintainer review fasttrack/2.0 PRs Destined for Azure Linux 2.0 Packaging security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Kanishk-Bansal @sameluch @jslobodzian @mfrw @PawelWMS