fix: Update channelServiceRoutes to add next() parameter to support restify 10.0.0+ #4429
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#minor
Fixes Internal: https://portal.microsofticm.com/imp/v3/incidents/details/365652257/home
Description
restify 10.0.0 and greater enforces the need for a
next()
callback that passes execution to the next function in the handler chain.channelServiceRoutes.ts
does not currently address this requirement. Since this class is required to interact with skills, this means that root bots that import this class will fail to start.Specific Changes
next: Function
parameter to the handlers inchannelServiceRoutes.ts
return next()
statement to the aforementioned handlerschannelServiceRoutes.test.js
to pass in an emptyFunction
asnext
in each testTesting
Ran the updated unit tests successfully.