fix: Add signInSso cardviewType to SignInCardViewParameters #4872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ceciliaavila do you mind helping clarify the test failure here? I'm confused by how my change is related to it. Thanks for your help! |
Hi @bentsai10, the test check failed with a transient error. It passed at re-run. |
|
Awesome, @ceciliaavila do you mind reviewing this one? Thank you! |
ceciliaavila
approved these changes
Mar 31, 2025
|
@ceciliaavila now that this change has merged, do you know approximately when the next release will be? Thanks for your help! |
Hi @bentsai10, @tracyboehrer decides about releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#minor
Description
See title. Need this additional cardViewType to achieve symmetry with documentation for .NET SDK
Specific Changes
Testing