Fix lints for Rust 1.85 #880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Classic clippy. Thanks for looking into this. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly cleaning up some more map_ors, but the one big change of note is temporarily allowing the clippy:precedence lint. Previously this lint only applied to arithmetic operations, however a change in 1.85 causes it to apply to bitwise operations as well. This is overly noisy, and unnecessary. And the clippy maintainers agree, as they've since split out this change into a separate lint, precedence_bits, that is allow-by-default. However that split will not be present until 1.86. See rust-lang/rust-clippy#14115 for details on that.