Skip to content

Conversation

@MattIrv
Copy link
Contributor

@MattIrv MattIrv commented Jul 19, 2017

To be consistent with our changes to SQL Tools Service and Carbon, connection option names should be capitalized like 'Use SSL compression' rather than 'Use SSL Compression'

@MattIrv MattIrv requested a review from AbbiePetcht July 19, 2017 00:25
@msftclas
Copy link

@MattIrv,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@MattIrv
Copy link
Contributor Author

MattIrv commented Jul 19, 2017

Automatically kicked off a Jenkins build for your branch fix/connectionOptionNameCase

70162a3: http://xplat-build-vm:8080/job/pgtoolsservice_custom-branch/180/

Build status: success
Tests passing: 299
Coverage: 92.54%

@AbbiePetcht
Copy link

:shipit:

@MattIrv MattIrv merged commit f21a22c into master Jul 19, 2017
@MattIrv MattIrv deleted the fix/connectionOptionNameCase branch July 19, 2017 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants