Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: microsoft/playwright-python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: bd4fa2a
Choose a base ref
...
head repository: microsoft/playwright-python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 920bc4d
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Dec 6, 2024

  1. cherry-pick(#2671): devops: fix build process producing wheels with i…

    …ncorrect RECORD
    ttm56p authored and mxschmitt committed Dec 6, 2024
    Copy the full SHA
    c8d2385 View commit details

Commits on Dec 10, 2024

  1. Copy the full SHA
    920bc4d View commit details
Showing with 5 additions and 6 deletions.
  1. +5 −6 setup.py
11 changes: 5 additions & 6 deletions setup.py
Original file line number Diff line number Diff line change
@@ -21,7 +21,7 @@
import zipfile
from typing import Dict

driver_version = "1.49.0-beta-1732210972000"
driver_version = "1.49.1"

base_wheel_bundles = [
{
@@ -165,13 +165,12 @@ def _build_wheel(
for whlfile in glob.glob(os.path.join(self.dist_dir, "*.whl")):
os.makedirs("wheelhouse", exist_ok=True)
if InWheel:
with InWheel(
in_wheel=whlfile,
out_wheel=os.path.join("wheelhouse", os.path.basename(whlfile)),
):
wheelhouse_whl = os.path.join("wheelhouse", os.path.basename(whlfile))
shutil.move(whlfile, wheelhouse_whl)
with InWheel(in_wheel=wheelhouse_whl, out_wheel=whlfile):
print(f"Updating RECORD file of {whlfile}")
print("Copying new wheels")
shutil.move("wheelhouse", self.dist_dir)
shutil.rmtree("wheelhouse")

def _download_and_extract_local_driver(
self,