Skip to content

fix(api): remove browserType.connect() #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 11, 2020

Conversation

yury-s
Copy link
Member

@yury-s yury-s commented Nov 11, 2020

No description provided.

@yury-s yury-s merged commit aa6790e into microsoft:master Nov 11, 2020
@vania-pooh
Copy link

@yury-s what is the expected way of directly connecting to web-socket having connect() method removed? Without such feature parallel remote execution is impossible.

@yury-s
Copy link
Member Author

yury-s commented Dec 11, 2020

We are going to implement connect at the Playwright level, i.e. the client would be able to do something like new Playwright(<websocket address> and from that point talk to the remote server same way as if it was running locally. Otherwise with the previous connect API we first need to establish connection to local playwright driver and then call connect on it passing url for each browser individually. This seemed sub-optimal.

@vania-pooh
Copy link

@yury-s: any related issues or time estimates?

@yury-s
Copy link
Member Author

yury-s commented Dec 11, 2020

Just filed microsoft/playwright#4687 We'll likely have it soon given that we are deprecating connect() but probably after 1.7 (which we is gonna be next week or so).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants