devops: push Docker image to MCR #299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
force-pushed
the
devops/push-image-mcr
branch
from
3d97646 to
b099d0b
Compare
mxschmitt
force-pushed
the
devops/push-image-mcr
branch
from
b099d0b to
157ff93
Compare
|
I don't get it why its failing, maybe someone has an idea? |
|
@pavelfeldman not sure why its failing, only the video test, hmm. |
| @@ -0,0 +1,43 @@ | |||
| name: "devrelease:docker" | |||
There was a problem hiding this comment.
Curious, why do we need this one?
There was a problem hiding this comment.
We can also remove the canary builds. They were useful for testing and Lushnikov and me used them a lot so I think it brings value.
aslushnikov
approved these changes
Nov 24, 2020
aslushnikov
reviewed
Nov 24, 2020
… into devops/push-image-mcr
aslushnikov
suggested changes
Nov 24, 2020
There was a problem hiding this comment.
Marking as "request changes" to not merge accidentally since this the tests are actually failing in the container.
@mxschmitt is looking into this
mxschmitt
force-pushed
the
devops/push-image-mcr
branch
from
7f1f9d1 to
0e7327f
Compare
aslushnikov
approved these changes
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #290
DOCKER_PASSWORDenvironment variable needs to be set.