Skip to content

chore: Remove MANIFEST.in #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2020
Merged

chore: Remove MANIFEST.in #315

merged 1 commit into from
Nov 24, 2020

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Nov 21, 2020

Removed MANIFEST.in as it is no longer required.

@kumaraditya303 kumaraditya303 changed the title chore: Remove unnecessary files from MANIFEST.in chore: Remove MANIFEST.in Nov 21, 2020
@pavelfeldman
Copy link
Member

Not a Python expert, could you help me understand how setup.py bdist_wheel knows which files to pick?

@kumaraditya303
Copy link
Contributor Author

@pavelfeldman MANIFEST.in is only used for source distribution i.e. python setup.py sdist whereas when creating a wheel archive, all the files in the directory are included even the non-python files so running python setup.py bdist_wheel picks all the files. See even without MANIFEST.in wheels picks up all the required files -

running bdist_wheel
running build
running build_py
copying playwright\_repo_version.py -> build\lib\playwright
running egg_info
writing playwright.egg-info\PKG-INFO
writing dependency_links to playwright.egg-info\dependency_links.txt
writing requirements to playwright.egg-info\requires.txt
writing top-level names to playwright.egg-info\top_level.txt
writing manifest file 'playwright.egg-info\SOURCES.txt'
installing to build\bdist.win-amd64\wheel
running install
running install_lib
creating build\bdist.win-amd64\wheel
creating build\bdist.win-amd64\wheel\playwright
copying build\lib\playwright\accessibility.py -> build\bdist.win-amd64\wheel\.\playwright
copying build\lib\playwright\async_api.py -> build\bdist.win-amd64\wheel\.\playwright
copying build\lib\playwright\async_base.py -> build\bdist.win-amd64\wheel\.\playwright
copying build\lib\playwright\browser.py -> build\bdist.win-amd64\wheel\.\playwright
copying build\lib\playwright\browser_context.py -> build\bdist.win-amd64\wheel\.\playwright
copying build\lib\playwright\browser_type.py -> build\bdist.win-amd64\wheel\.\playwright
copying build\lib\playwright\cdp_session.py -> build\bdist.win-amd64\wheel\.\playwright
copying build\lib\playwright\chromium_browser_context.py -> build\bdist.win-amd64\wheel\.\playwright
copying build\lib\playwright\connection.py -> build\bdist.win-amd64\wheel\.\playwright
copying build\lib\playwright\console_message.py -> build\bdist.win-amd64\wheel\.\playwright
copying build\lib\playwright\dialog.py -> build\bdist.win-amd64\wheel\.\playwright
copying build\lib\playwright\download.py -> build\bdist.win-amd64\wheel\.\playwright
copying build\lib\playwright\element_handle.py -> build\bdist.win-amd64\wheel\.\playwright
copying build\lib\playwright\event_context_manager.py -> build\bdist.win-amd64\wheel\.\playwright
copying build\lib\playwright\file_chooser.py -> build\bdist.win-amd64\wheel\.\playwright
copying build\lib\playwright\frame.py -> build\bdist.win-amd64\wheel\.\playwright
copying build\lib\playwright\helper.py -> build\bdist.win-amd64\wheel\.\playwright
copying build\lib\playwright\impl_to_api_mapping.py -> build\bdist.win-amd64\wheel\.\playwright
copying build\lib\playwright\input.py -> build\bdist.win-amd64\wheel\.\playwright
copying build\lib\playwright\js_handle.py -> build\bdist.win-amd64\wheel\.\playwright
copying build\lib\playwright\main.py -> build\bdist.win-amd64\wheel\.\playwright
copying build\lib\playwright\network.py -> build\bdist.win-amd64\wheel\.\playwright
copying build\lib\playwright\object_factory.py -> build\bdist.win-amd64\wheel\.\playwright
copying build\lib\playwright\page.py -> build\bdist.win-amd64\wheel\.\playwright
copying build\lib\playwright\path_utils.py -> build\bdist.win-amd64\wheel\.\playwright
copying build\lib\playwright\playwright.py -> build\bdist.win-amd64\wheel\.\playwright
copying build\lib\playwright\py.typed -> build\bdist.win-amd64\wheel\.\playwright
copying build\lib\playwright\selectors.py -> build\bdist.win-amd64\wheel\.\playwright
copying build\lib\playwright\sync_api.py -> build\bdist.win-amd64\wheel\.\playwright
copying build\lib\playwright\sync_base.py -> build\bdist.win-amd64\wheel\.\playwright
copying build\lib\playwright\transport.py -> build\bdist.win-amd64\wheel\.\playwright
copying build\lib\playwright\video.py -> build\bdist.win-amd64\wheel\.\playwright
copying build\lib\playwright\wait_helper.py -> build\bdist.win-amd64\wheel\.\playwright
copying build\lib\playwright\_repo_version.py -> build\bdist.win-amd64\wheel\.\playwright
copying build\lib\playwright\__init__.py -> build\bdist.win-amd64\wheel\.\playwright
copying build\lib\playwright\__main__.py -> build\bdist.win-amd64\wheel\.\playwright
running install_egg_info
Copying playwright.egg-info to build\bdist.win-amd64\wheel\.\playwright-0.152.0.post23+g7adbb72-py3.9.egg-info
running install_scripts
adding license file "LICENSE" (matched pattern "LICEN[CS]E*")
creating build\bdist.win-amd64\wheel\playwright-0.152.0.post23+g7adbb72.dist-info\WHEEL
creating 'dist\playwright-0.152.0.post23+g7adbb72-py3-none-any.whl' and adding 'build\bdist.win-amd64\wheel' to it
adding 'playwright/__init__.py'
adding 'playwright/__main__.py'
adding 'playwright/_repo_version.py'
adding 'playwright/accessibility.py'
adding 'playwright/async_api.py'
adding 'playwright/async_base.py'
adding 'playwright/browser.py'
adding 'playwright/browser_context.py'
adding 'playwright/browser_type.py'
adding 'playwright/cdp_session.py'
adding 'playwright/chromium_browser_context.py'
adding 'playwright/connection.py'
adding 'playwright/console_message.py'
adding 'playwright/dialog.py'
adding 'playwright/download.py'
adding 'playwright/element_handle.py'
adding 'playwright/event_context_manager.py'
adding 'playwright/file_chooser.py'
adding 'playwright/frame.py'
adding 'playwright/helper.py'
adding 'playwright/impl_to_api_mapping.py'
adding 'playwright/input.py'
adding 'playwright/js_handle.py'
adding 'playwright/main.py'
adding 'playwright/network.py'
adding 'playwright/object_factory.py'
adding 'playwright/page.py'
adding 'playwright/path_utils.py'
adding 'playwright/playwright.py'
adding 'playwright/py.typed'
adding 'playwright/selectors.py'
adding 'playwright/sync_api.py'
adding 'playwright/sync_base.py'
adding 'playwright/transport.py'
adding 'playwright/video.py'
adding 'playwright/wait_helper.py'
adding 'playwright-0.152.0.post23+g7adbb72.dist-info/LICENSE'
adding 'playwright-0.152.0.post23+g7adbb72.dist-info/METADATA'
adding 'playwright-0.152.0.post23+g7adbb72.dist-info/WHEEL'
adding 'playwright-0.152.0.post23+g7adbb72.dist-info/top_level.txt'
adding 'playwright-0.152.0.post23+g7adbb72.dist-info/RECORD'
removing build\bdist.win-amd64\wheel

MANIFEST.in docs

@pavelfeldman pavelfeldman merged commit 8c6d4e4 into microsoft:master Nov 24, 2020
@kumaraditya303 kumaraditya303 deleted the patch-pypi branch November 24, 2020 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants