Skip to content

fix(transport): handle connection error correctly (#650) #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 4, 2021
Merged

fix(transport): handle connection error correctly (#650) #651

merged 11 commits into from
May 4, 2021

Conversation

x0day
Copy link
Contributor

@x0day x0day commented Apr 26, 2021

@ghost
Copy link

ghost commented Apr 26, 2021 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

kumaraditya303
kumaraditya303 reviewed Apr 26, 2021
View reviewed changes
@mxschmitt
Copy link
Member

A test for ws connection timeout for sync and async would be awesome.

@x0day
Copy link
Contributor Author

x0day commented Apr 26, 2021

A test for ws connection timeout for sync and async would be awesome.

ok

x0day
x0day commented Apr 26, 2021
View reviewed changes
@x0day
Copy link
Contributor Author

x0day commented Apr 27, 2021

add the test test_connect_to_closed_server_without_hangs, please check.

@x0day x0day requested a review from mxschmitt April 27, 2021 06:25
kumaraditya303
kumaraditya303 suggested changes Apr 27, 2021
View reviewed changes
mxschmitt
mxschmitt reviewed Apr 27, 2021
View reviewed changes
Copy link
Member

@mxschmitt mxschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but the currently handling of having run and start is confusing I think from my perspective. Will take a more detailed look later how to avoid that.

@x0day
Copy link
Contributor Author

x0day commented Apr 27, 2021

Looks good but the currently handling of having run and start is confusing I think from my perspective. Will take a more detailed look later how to avoid that.

yep maybe we can fix hang error at this time and think about allow channel be inited after connect or launch at next version.

@mxschmitt mxschmitt mentioned this pull request May 3, 2021
Closed
@mxschmitt mxschmitt merged commit 82885a1 into microsoft:master May 4, 2021
pavelfeldman added a commit to pavelfeldman/playwright-python that referenced this pull request May 7, 2021
@pavelfeldman
Revert "fix(transport): handle connection error correctly (microsoft#650
9b6e400 
) (microsoft#651)"

This reverts commit 82885a1.
Sorry about the revert. I don't think this handles the connection
timeout properly, so let me see if we can get a better fix here.
pavelfeldman added a commit that referenced this pull request May 7, 2021
@pavelfeldman
Revert "fix(transport): handle connection error correctly (#650) (#651)…
034c221 
…" (#670)

This reverts commit 82885a1.
Sorry about the revert. I don't think this handles the connection
timeout properly, so let me see if we can get a better fix here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxschmitt mxschmitt mxschmitt left review comments

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@x0day @mxschmitt @kumaraditya303