Skip to content

feat: conda support #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 11, 2021
Merged

feat: conda support #657

merged 3 commits into from
May 11, 2021

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Apr 30, 2021 •
edited by mxschmitt
Loading

Fixes #257

@kumaraditya303 kumaraditya303 mentioned this pull request Apr 30, 2021
Closed
@mxschmitt
Copy link
Member

Status-update: waiting for credentials on our side.

xiangyan99
xiangyan99 reviewed May 10, 2021
View reviewed changes
zooba
zooba reviewed May 10, 2021
View reviewed changes
mxschmitt
mxschmitt approved these changes May 11, 2021
View reviewed changes
Copy link
Member

@mxschmitt mxschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mxschmitt
mxschmitt reviewed May 11, 2021
View reviewed changes
mxschmitt
mxschmitt reviewed May 11, 2021
View reviewed changes
@mxschmitt
Copy link
Member

mxschmitt commented May 11, 2021 •
edited
Loading

Would also be nice if you could add some docs, I thought about a badge (ref: https://shields.io):

Conda

(with a link to anaconda.org)

and maybe under usage a code block for anaconda with

conda config --add channels conda-forge
conda install -c microsoft playwright

.

@kumaraditya303
Copy link
Contributor Author

Will add docs in a following PR.

@kumaraditya303 kumaraditya303 requested a review from mxschmitt May 11, 2021 10:00
@zooba
Copy link
Member

zooba commented May 11, 2021

I thought about a badge

Not sure if you need to be logged in to see it, but there are badges provided by anaconda.org at https://anaconda.org/Microsoft/playwright/badges

@mxschmitt mxschmitt merged commit 2c5687a into microsoft:master May 11, 2021
mxschmitt pushed a commit that referenced this pull request May 11, 2021
@kumaraditya303 @mxschmitt
feat: conda support (#657)
cf08799
@owenlamont owenlamont mentioned this pull request Jul 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zooba zooba zooba left review comments

@xiangyan99 xiangyan99 xiangyan99 left review comments

@mxschmitt mxschmitt mxschmitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support the conda package manager for installation
4 participants
@kumaraditya303 @mxschmitt @zooba @xiangyan99