Skip to content

feat(roll): roll to Playwright 1.12.0-next-1621456974000 #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 21, 2021
Merged

feat(roll): roll to Playwright 1.12.0-next-1621456974000 #682

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f8eeada
feat(roll): roll to Playwright 1.12.0-next-1621315694000
kumaraditya303 May 12, 2021
a969620
roll to latest driver version
mxschmitt May 19, 2021
ad92391
cleanup
mxschmitt May 20, 2021
063b96b
drop skip
mxschmitt May 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
cleanup
  • Loading branch information
@mxschmitt
mxschmitt committed May 20, 2021
commit ad923917948ed74feaf80a0a74018987ae9f989f
9 changes: 4 additions & 5 deletions playwright/_impl/_tracing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,10 @@


class Tracing:
def __init__(self, channel: "BrowserContext") -> None:
self._context = channel
self._channel = channel._channel # type: ignore
self._loop = channel._loop
self._dispatcher_fiber = channel._dispatcher_fiber
def __init__(self, context: "BrowserContext") -> None:
self._context = context
self._channel = context._channel
self._loop = context._loop

async def start(
self, name: str = None, snapshots: bool = None, screenshots: bool = None
Expand Down