fix: exception when page got closed via browser in persistent context #685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
approved these changes
May 12, 2021
mxschmitt
force-pushed
the
bugfix/persistent-context-error
branch
from
5a0836f to
f6472a8
Compare
pavelfeldman
approved these changes
May 12, 2021
YusukeIwaki
added a commit
to YusukeIwaki/playwright-ruby-client
that referenced
this pull request
May 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #681
not sure about a test for it.
A Set in JavaScript simply does not throw when there is no element which gets removed.
it throws here:
playwright-python/playwright/_impl/_page.py
Line 274 in 9d79662