Skip to content

fix(types): added types for devices #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2020
Merged

fix(types): added types for devices #90

merged 1 commit into from
Jul 25, 2020

Conversation

mxschmitt
Copy link
Member

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 181410579

  • 19 of 25 (76.0%) changed or added relevant lines in 4 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.3%) to 84.19%
Changes Missing Coverage Covered Lines Changed/Added Lines %
playwright/sync_base.py 12 14 85.71%
playwright/sync.py 2 6 33.33%
Files with Coverage Reduction New Missed Lines %
playwright/sync.py 2 67.09%
playwright/main.py 5 86.84%
Totals Coverage Status
Change from base Build 181270950: -0.3%
Covered Lines: 2343
Relevant Lines: 2783
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 24, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 182381868

  • 9 of 9 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 84.493%
Totals Coverage Status
Change from base Build 181417714: 0.02%
Covered Lines: 2343
Relevant Lines: 2773
💛 - Coveralls

@mxschmitt mxschmitt force-pushed the bugfix/wrap-route branch from 493ccff to 5b237e8 Compare July 25, 2020 15:11
@mxschmitt mxschmitt changed the title fix(sync): wrap route callback args in sync class fix(types): added types for devices Jul 25, 2020
@mxschmitt mxschmitt force-pushed the bugfix/wrap-route branch from 5b237e8 to 7a820bd Compare July 25, 2020 15:26
@pavelfeldman pavelfeldman merged commit 2343ff1 into microsoft:master Jul 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelfeldman pavelfeldman pavelfeldman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mxschmitt @coveralls @pavelfeldman