Skip to content

Properly parse @$x += $y as @($x += $y) #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2019
Merged

Properly parse @$x += $y as @($x += $y) #282

merged 1 commit into from
Mar 9, 2019

Conversation

TysonAndre
Copy link
Contributor

Fixes one edge case in #19

Also, fix parsing of @$x instanceof $y.
My earlier PR fixed !$x instanceof $y but broke that.

roblourens
roblourens approved these changes Mar 9, 2019
View reviewed changes
Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good to me. I'll let you fix the merge conflict.

@TysonAndre
Properly parse @$x += $y as @($x += $y)
0a96f2e 
Fixes one edge case in microsoft#19

Also, fix parsing of `@$x instanceof $y`.
My earlier PR fixed `!$x instanceof $y` but broke that.
@TysonAndre TysonAndre force-pushed the force-assignment-expression branch from 3f9c698 to 0a96f2e Compare March 9, 2019 19:10
@TysonAndre
Copy link
Contributor Author

ok, fixed

@roblourens roblourens merged commit 89386de into microsoft:master Mar 9, 2019
@TysonAndre TysonAndre deleted the force-assignment-expression branch March 27, 2021 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roblourens roblourens roblourens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TysonAndre @roblourens