Fix 8.4 Deprecations and bump library to 8.0 #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

dantleech wants to merge 3 commits into microsoft:main from dantleech:8.4

Contributor

dantleech commented Oct 12, 2024 •

edited

Loading

8.4 deprecates implicitly nullable parameters

This library however supports PHP 7.2 which does not support explicit nullable types (i.e. ?string) and was end-of-life over 4 years ago.

This PR:

Bumps the minimum PHP version to 8.0 (which is also end-of-life, maybe a good move to go to 8.1?)
Introduces rector as a dev dependency to facilitate these types of refactoring.
Adds switches from implicitly nullable to explicitly nullable parameters.

cc @roblourens @TysonAndre what do you think?

dantleech added 3 commits

October 12, 2024 14:45


          Introduce rector

f539ccf


          Fix 8.4 deprecations, bump library to 8.0

5c801b1


          Merge branch 'main' into 8.4

08e6ff5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet