Watch files over LSP #806
Open
Watch files over LSP #806
+1,017
−83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for watching files over LSP by integrating file watcher functionality into various parts of the project and refactoring how file events are processed.
- Introduces new file watch APIs and methods in the project and LSP server modules.
- Refactors and propagates comparePathsOptions, file watchers, and diagnostic publishing across services and tests.
- Updates tests and utilities for consistent use of configuration and file watching.
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/tsoptions/* | Introduces new utility functions for pattern matching. |
| internal/project/* | Adds file watcher fields and update logic in projects. |
| internal/lsp/server.go | Integrates LSP file watch requests, notifications, and dynamic registration. |
| internal/api/api.go | Updates to script info creation reflecting FS injection. |
| internal/testutil/projecttestutil/projecttestutil.go | Refactors file variable naming to improve consistency. |
Comments suppressed due to low confidence (1)
internal/lsp/server.go:70
- The variable name 'watcheEnabled' appears to have a typo. Consider renaming it to 'watchEnabled' for clarity and consistency.
watcheEnabled bool
jakebailey
reviewed
May 8, 2025
| Method Method `json:"method"` | ||
| Params any `json:"params"` | ||
| } | ||
|
|
||
| func NewRequestMessage(method Method, id *ID, params any) *RequestMessage { | ||
| return &RequestMessage{ | ||
| JSONRPC: JSONRPCVersion{}, |
There was a problem hiding this comment.
Suggested change
| JSONRPC: JSONRPCVersion{}, |
No need to specify this since it's zero'd.
| @@ -62,36 +67,100 @@ type Server struct { | |||
| initializeParams *lsproto.InitializeParams | |||
| positionEncoding lsproto.PositionEncodingKind | |||
|
|
|||
| watcheEnabled bool | |||
| watcherID int | |||
| watchers map[project.WatcherHandle]struct{} | |||
There was a problem hiding this comment.
Is this just a core.Set[project.WatcherHandle]?
There was a problem hiding this comment.
Oh yeah, I forgot we had something other than OrderedSet
| @@ -262,9 +363,14 @@ func (s *Server) handleInitialize(req *lsproto.RequestMessage) error { | |||
| } | |||
|
|
|||
| func (s *Server) handleInitialized(req *lsproto.RequestMessage) error { | |||
| if s.initializeParams.Capabilities.Workspace.DidChangeWatchedFiles != nil && *s.initializeParams.Capabilities.Workspace.DidChangeWatchedFiles.DynamicRegistration { | |||
| s.watcheEnabled = true | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds LSP file watching requests for wildcard directories, failed/affecting lookup locations, and tsconfig files.