Detect when local server cannot be connected to

[barde]

Issue Type: Bug

When running in a container all login methods for Azure (Device Code and the default way with redirect to localhost:37207) fail. There is no error message and the GUI offers me to log in.

This can be tested by running in a ChromeOS crostini environment.

VS Code version: Code 1.30.2 (61122f88f0bf01e2ac16bdb9e1bc4571755f5bd8, 2019-01-07T22:49:48.319Z)
OS version: Linux x64 4.14.74-07776-gac52e5f750c8

System Info

Item	Value
CPUs	06/8e (4 x 1607)
GPU Status	2d_canvas: unavailable_software checker_imaging: disabled_off flash_3d: unavailable_software flash_stage3d: unavailable_software flash_stage3d_baseline: unavailable_software gpu_compositing: unavailable_software multiple_raster_threads: enabled_on native_gpu_memory_buffers: disabled_software rasterization: unavailable_software video_decode: unavailable_software video_encode: unavailable_software webgl: enabled_readback webgl2: unavailable_off
Load (avg)	0, 0, 0
Memory (System)	10.63GB (6.40GB free)
Process Argv
Screen Reader	no
VM	100%

Extensions (9)

Extension	Author (truncated)	Version
vscode-azureappservice	ms-	0.11.0
vscode-azurefunctions	ms-	0.13.1
vscode-azurestorage	ms-	0.5.0
azure-account	ms-	0.8.0
azurecli	ms-	0.4.2
vscode-node-azure-pack	ms-	0.0.5
team	ms-	1.144.1
azurerm-vscode-tools	msa	0.4.2
vscode-docker	Pet	0.5.1

[jpgilchrist]

I too am running into this, and would love to see it resolved.

[chrmarti]

Does your system have gnome-keyring installed?

[barde]

~ gnome-keyring fish: Unknown command 'gnome-keyring'

No.

[barde]

I suppose the redirect does not work as the launched browser from Crostini is the "native" one from ChromeOS which does not find the opened port on the crostini VM as it is probably not redirected to the ChromeOS host.

[chrmarti]

@barde Could you try the device code sign-in? That is less convenient, but should work in this case.

[barde]

After confirming the device code VS Code shows a non-logged in interface.

[chrmarti]

Did the website ask you to pick an account and sign-in to that? Is there anything in the console (Help > Toggle Developer Tools)?

[barde]

After deleting all cookies from Azure, updating VS Code and trying to do the device-login it works.
Sadly, just after restarting VS Code the registration is not there anymore and I have to redo a device login.

Still, the issue with the original callback method is somewhat annoying. Maybe it could be deactivated on VS Code running in a Chromebook emulation without real localhost passthrough?

[chrmarti]

I have seen deletion of cookies help before. 👍

We rely on the keytar NPM package which needs gnome-keyring for storing tokens. Not sure what we can do there. (atom/node-keytar#74)

If we can detect that the local server won't be reachable from the browser, we can automatically fall back to the device code sign-in. Unfortunately I don't know of a way for doing that.