Initial code for switching database on the current server #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const self = this; | ||
| return new Promise<Interfaces.IConnectionCredentials>((resolve, reject) => { | ||
| // create a new connection to the master db using the current connection as a base | ||
| const masterCredentials = <Interfaces.IConnectionCredentials> { |
There was a problem hiding this comment.
I think we're binding to ES6 - can we use Object.assign per microsoft/TypeScript#3429? This would avoid the very manual, hacky copying of properties. It would be much easier to clone & change database value afterwards.
There was a problem hiding this comment.
If this is hard please skip - we can probably add support in the .Net layer instead.
|
Looks like you need to handle merge conflicts before submitting - otherwise looks good (with some comments). Given we'll fix up once we move to service layer, I'm not too concerned.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial hacky solution that queries sys.databases to find a list of databases on the current server. Just thought I'd get this out for review so we can get it in sooner rather than later.