Skip to content

Support pythonTerminalEnvVarActivation experiment in multiroot workspaces #21047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Apr 23, 2023
Merged

Support pythonTerminalEnvVarActivation experiment in multiroot workspaces #21047

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
6b2f652
Build VSIX
Apr 13, 2023
9ecdd05
build vsix
Apr 13, 2023
15c3c6c
Merge branch 'main' of https://github.com/microsoft/vscode-python int…
Apr 13, 2023
9fd0f70
yo
Apr 13, 2023
c27fd0c
Switch package.json
Apr 13, 2023
40e2154
More fixes
Apr 13, 2023
4f9a51e
oops
Apr 13, 2023
460e5ba
Mkae env collection simpler for testing
Apr 13, 2023
28b9347
Revert "Mkae env collection simpler for testing"
Apr 14, 2023
b9261a7
Support description
Apr 14, 2023
9199dcc
Fix
Apr 15, 2023
633b9b4
Add backticks
Apr 15, 2023
1316e6b
Use markdown string
Apr 21, 2023
547b91c
Merge branch 'main' of https://github.com/microsoft/vscode-python int…
Apr 21, 2023
91ac3bf
Fix unit tests
Apr 21, 2023
6ac662b
Add tests
Apr 21, 2023
869b090
Update vscode engine
Apr 21, 2023
59c678d
Wrap try catch around proposed APIs
Apr 21, 2023
2cde3d5
Revert "build vsix"
Apr 21, 2023
7be4f9f
Use latest insiders
Apr 21, 2023
87409d6
Oops
Apr 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix
  • Loading branch information
Kartik Raj committed Apr 15, 2023
commit 9199dccf4aa4ceea2332a446b9bda96c4ca3fa60
2 changes: 1 addition & 1 deletion src/client/interpreter/activation/terminalEnvVarCollectionService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ export class TerminalEnvVarCollectionService implements IExtensionActivationServ
await this._applyCollection(resource, defaultShell?.shell);
return;
}
this.context.environmentVariableCollection.clear();
this.context.environmentVariableCollection.clear({ workspaceFolder });
this.previousEnvVars = _normCaseKeys(process.env);
return;
}
Expand Down
2 changes: 2 additions & 0 deletions types/vscode.proposed.envCollectionWorkspace.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ declare module 'vscode' {
prepend(variable: string, value: string, scope?: EnvironmentVariableScope): void;
get(variable: string, scope?: EnvironmentVariableScope): EnvironmentVariableMutator | undefined;
delete(variable: string, scope?: EnvironmentVariableScope): void;
clear(scope?: EnvironmentVariableScope): void;

}

export type EnvironmentVariableScope = {
Expand Down