Skip to content

Remove coil2/3 dependency from core module | Introduce standalone dependencies #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

mikepenz
Copy link
Owner

@mikepenz mikepenz commented Jun 7, 2024


Image Loading

Starting with 0.21.0 the library does not include image loading by default, however exposes 2
modules for either coil2 or coil3 dependencies.
The chosen image transformer implementation has to be passed to the Markdown API.

coil2

// Offers coil2 (Coil2ImageTransformerImpl)
implementation("com.mikepenz:multiplatform-markdown-renderer-coil2:${version}")
Markdown(
    MARKDOWN,
    imageTransformer = Coil2ImageTransformerImpl,
)

Note

0.21.0 adds JVM support for this dependency via HTTPUrlConnection -> however this is expected to be removed in the future.

Note

Please refer to the official coil2 documentation on how to adjust the ImageLoader

coil3

// Offers coil3 (Coil3ImageTransformerImpl)
implementation("com.mikepenz:multiplatform-markdown-renderer-coil3:${version}")
Markdown(
    MARKDOWN,
    imageTransformer = Coil3ImageTransformerImpl,
)

Note

Please refer to the official coil3 documentation on how to adjust the SingletonImageLoader

Note

The coil3 module does depend on SNAPSHOT builds of coil3

  - FIX #154
- introduce coil2 and coil3 modules respectively
@mikepenz mikepenz merged commit 51a1140 into develop Jun 7, 2024
3 checks passed
@mikepenz mikepenz deleted the feature/154 branch June 7, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.20.0 depends on a Coil snapshot
1 participant