Add viewport meta tag to index.html
#360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Migrate styles to `styles.css`.
keta1
changed the title
index.html.index.html
mikepenz
approved these changes
Mar 30, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes mobile display by adding a viewport meta tag, migrating styles to a dedicated stylesheet, and centralizing error handling for unsupported browsers into a new JavaScript file.
- Introduce error handling for unsupported browsers that addresses specific WebAssembly compilation issues.
- Migrate error handling logic to a new file (unsupported_browser.js).
Files not reviewed (2)
- sample/web/src/commonMain/resources/index.html: Language not supported
- sample/web/src/commonMain/resources/styles.css: Language not supported
Comment on lines
+3
to
+4
| document.getElementById("warning").style.display = "initial"; | ||
|
|
There was a problem hiding this comment.
Add a null check for the element with id 'warning' before modifying its style to prevent potential runtime errors.
Suggested change
| document.getElementById("warning").style.display = "initial"; | |
| const warningElement = document.getElementById("warning"); | |
| if (warningElement != null) { | |
| warningElement.style.display = "initial"; | |
| } |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mobile Display Optimization
Content Updates
index.htmlstyles.cssunsupported_browser.jsDescription
Fixed the display of sample on mobile
Comparison