Skip to content

enhance: support more ddl apis to replicate according to cdc #41678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented May 7, 2025

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label May 7, 2025
Copy link
Contributor

mergify bot commented May 7, 2025

@SimFG Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added needs-dco DCO is missing in this pull request. kind/enhancement Issues or changes related to enhancement labels May 7, 2025
@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels May 7, 2025
Copy link

codecov bot commented May 7, 2025

Codecov Report

Attention: Patch coverage is 41.00719% with 164 lines in your changes missing coverage. Please review.

Project coverage is 80.52%. Comparing base (f62a2e2) to head (f7dfa1d).
Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
pkg/mq/msgstream/msg_for_collection.go 9.09% 89 Missing and 1 partial ⚠️
pkg/mq/msgstream/msg_for_alias.go 28.12% 66 Missing and 3 partials ⚠️
internal/proxy/task.go 33.33% 4 Missing ⚠️
internal/proxy/impl.go 93.75% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #41678      +/-   ##
==========================================
- Coverage   80.59%   80.52%   -0.08%     
==========================================
  Files        1508     1510       +2     
  Lines      213283   213602     +319     
==========================================
+ Hits       171902   172007     +105     
- Misses      35213    35422     +209     
- Partials     6168     6173       +5     
Components Coverage Δ
Client 79.38% <ø> (ø)
Core 73.89% <ø> (-0.07%) ⬇️
Go 81.84% <41.00%> (-0.08%) ⬇️
Files with missing lines Coverage Δ
internal/proxy/task_alias.go 94.81% <100.00%> (+0.34%) ⬆️
internal/proxy/util.go 85.66% <100.00%> (+0.23%) ⬆️
pkg/mq/msgdispatcher/dispatcher.go 88.42% <100.00%> (+0.04%) ⬆️
pkg/mq/msgstream/unmarshal.go 100.00% <100.00%> (ø)
internal/proxy/impl.go 82.06% <93.75%> (+<0.01%) ⬆️
internal/proxy/task.go 82.71% <33.33%> (-0.35%) ⬇️
pkg/mq/msgstream/msg_for_alias.go 28.12% <28.12%> (ø)
pkg/mq/msgstream/msg_for_collection.go 45.45% <9.09%> (-36.37%) ⬇️

... and 43 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot added the ci-passed label May 7, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007
Copy link
Collaborator

czs007 commented May 8, 2025

This is a temporary solution.

@czs007
Copy link
Collaborator

czs007 commented May 8, 2025

/lgtm

@sre-ci-robot sre-ci-robot merged commit dfd2548 into milvus-io:master May 8, 2025
17 of 20 checks passed
sre-ci-robot pushed a commit that referenced this pull request May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants